[Diagram Editor] Better layout for cyclical connections

Open
#107 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
design, frontend

Research direction

Open diagrams/countdown.json in the Diagram Editor and inspect the current auto-layout behavior for the cycle involving sub and less_than. Clarify whether the contribution targets manual edge positioning, cycle-aware auto-layout, or both. Done should be demonstrated by a readable cycle layout and clearly defined behavior for adjusting connections.

Written by the indexing model from the issue text.

Description

The current auto-layout scheme works very well for workflows that only connect from top to bottom, but it gets a bit twisted up when a cycle shows up. Here's what diagrams/countdown.json currently looks like:

Image

This could be made to look good if the connection from sub to less_than were able to loop the long way around sub (to the left). I think we should consider the following upgrades to the UI:

  • Allow users to manually adjust the positioning of the edges (connections between operations)
  • Have an auto-layout that accounts for cycles by looping those connections outwards instead of taking the shortest path
Dominant language
Rust
Stars
75
Forks
18
Avg merge
12d 12h
Merged PRs (30d)
3

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from open-rmf/crossflow

All issues in open-rmf/crossflow

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.