Host: `HostConfig` is not deserializable
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Start at the HostConfig definition in tellus/src/host.rs (around lines 258-264), where only Debug, Clone and Copy are derived, and at with_idle_timeout, which already enforces the nonzero idle timeout. Follow how Backoff is deserialized through try_from behind the serde feature, and mirror it for HostConfig. Done when the type deserializes under that feature, and the claims in docs/actors.md:145 and tellus/src/lib.rs:63-67 match the code.
Written by the indexing model from the issue text.
Description
HostConfig derives only Debug, Clone and Copy (tellus/src/host.rs:258-264), so it cannot come from a configuration file. docs/actors.md:145 says "The serde feature makes the whole configuration deserializable", and the crate docs (tellus/src/lib.rs:63-67) list the deserializable configurations without it.
Its only invariant, a nonzero idle timeout, is already checked in with_idle_timeout. So deserializing through try_from, as Backoff does, would fit.
Adding the derive behind the serde feature is additive.
Found by reading the code at a320c3f.
- Dominant language
- Rust
- Stars
- 37
- Forks
- 1
- Avg merge
- 6h 20m
- Merged PRs (30d)
- 135
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from tellus-rs/tellus
-
documentation question
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
Maintainers usually reply within 1 day
-
good first issue test
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
tracking
Difficulty 5/5 Over a week Newbie friendliness 8/100
Maintainers usually reply within 1 day
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
Maintainers usually reply within 1 day
All issues in tellus-rs/tellus
Similar issues
-
comp-formats
Difficulty 2/5 Half a day Newbie friendliness 64/100
ClickHouse/ClickHouse#131694 ·
Maintainers usually reply within 1 day
-
cli: `execCargoMetadata` decodes stdout per chunk, corrupting non-ASCII paths across pipe boundariesOpen
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Copperpour/Copperpour#500 ·
Maintainers usually reply within 1 day
-
state:triage-needed
Difficulty 1/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
storytold/photocraft#14822 ·
Maintainers usually reply within 1 day