Hide upload options for users with 0 quota
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript
Research direction
Start in lib/Capabilities.php at the capability checks around lines 283 and 417–423. Read how the upload allowed value is set and how quota is checked; make zero quota disable uploads, including dropping files. Done means upload options are hidden and dropped files cannot be sent for users with no quota.
Written by the indexing model from the issue text.
Description
[!TIP]
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Steps to reproduce
- Have a user with no quota
- Be in Talk and try to upload something
Expected behaviour
The option should not be visible for users with no quota in the first place. Also dropping files should not work
Actual behaviour
Upload is visible and even tried, resulting in non-sent messages
Background
Here we only set allowed only based on the user backend (sidenote: that might change in the future as well, since there were changes in the guests app).
Since we already check the quota at
we should be able to set allowed to false in case of quota 0.
Talk app
Talk app version: 25.0.6
Browser
Operating system: Tested on Windows
Browser name: Chrome
- Dominant language
- JavaScript
- Stars
- 2.2k
- Forks
- 598
- Avg merge
- 21h 32m
- Merged PRs (30d)
- 391
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nextcloud/spreed
-
RTLOpenbug Needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
nextcloud/spreed#20093 · 1 comment ·
Maintainers usually reply within 1 day
-
bug feature: chat 💬 feature: frontend 🖌️ papercut regression
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
nextcloud/spreed#20013 · 1 comment ·
Maintainers usually reply within 1 day
-
TranscriptBlock: TypeError in updateLines/getLineBoundaries when a chunk has no layout boxes (empty getClientRects)Possibly taken @Antreesy claimed this 16 days ago. Openbug feature: call 📹 feature: frontend 🖌️
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nextcloud/spreed#19733 · 1 comment ·
Maintainers usually reply within 1 day
-
bug feature: frontend 🖌️ feature: settings ⚙️
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
nextcloud/spreed#19533 · 1 comment ·
Maintainers usually reply within 1 day
-
bug feature: conversations 👥 feature: frontend 🖌️ feature: search 🔎 good first issue papercut
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
nextcloud/spreed#19498 · 2 comments ·
Maintainers usually reply within 1 day
All issues in nextcloud/spreed
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
hexlet-codebattle/codebattle#2374 ·
-
docs: Code on siteOpen
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
saadeghi/daisyui#4846 · 1 comment ·
Maintainers usually reply within 4 days
-
spec-feedback
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
automated-link-issue broken-link
Difficulty 2/5 Half a day Newbie friendliness 65/100
JuanPabloDiaz/freeForGeeks#313 ·