`showLoading` and `showUndo` "ignore" `isHTML = true`
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start in lib/toast.ts around lines 213-223 to inspect how showLoading and showUndo handle text and isHTML. Check styles/toast.scss around lines 23-28, then verify that HTML text is rendered as intended without breaking the toast layout.
Written by the indexing model from the issue text.
Description
The showLoading and showUndo functions somewhat "ignore" isHTML = true, because they don't simply pass the text argument to showMessage, which itself just forwards it to Toastify, but they create a new element and set its innerText property to the value of text and then pass the whole element to showMessage.
I think it would be fine to do
const loaderContent = document.createElement('div')
loaderContent[options.isHTML ? 'innerHTML' : 'innerText'] = text
The containers are flex containers, so I think it won't be a problem
If you don't want to change this, I think it would be a good idea to at least remove isHTML from the options
export function showLoading(text: string, options?: Omit<ToastOptions, 'isHTML'>): Toast { }
- Dominant language
- TypeScript
- Stars
- 19
- Forks
- 8
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 46
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nextcloud-libraries/nextcloud-dialogs
-
Actions on ToastsOpen
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
nextcloud-libraries/nextcloud-dialogs#2669 ·
Maintainers usually reply within 1 day
-
ConflictPicker non-scoped styles leed to literal ":deep()" in css assets.Possibly taken @rotdrop claimed this 13 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
nextcloud-libraries/nextcloud-dialogs#2648 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
nextcloud-libraries/nextcloud-dialogs#2510 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
nextcloud-libraries/nextcloud-dialogs#2491 · 3 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
nextcloud-libraries/nextcloud-dialogs#2299 ·
Maintainers usually reply within 1 day
All issues in nextcloud-libraries/nextcloud-dialogs
Similar issues
-
area:tui enhancement platform:macos
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
anthropics/claude-code#101490 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
netlify/netlify-mcp#75 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
atlassian-labs/compiled#1960 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
pnp/cli-microsoft365#7639 ·
Maintainers usually reply within 2 days
-
nextjs-tracking
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
cloudflare/vinext#3887 ·
Maintainers usually reply within 1 day