ConflictPicker non-scoped styles leed to literal ":deep()" in css assets.
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 85/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start with the four referenced style blocks in lib/components/ConflictPicker/ConflictPicker.vue and lib/components/ConflictPicker/ConflictPickerCard.vue. Inspect how their style attributes affect the generated CSS, then build the package and check dist/style.css with grep :deep; done means the stray literal :deep selectors no longer appear.
Written by the indexing model from the issue text.
Description
I think these lines in ConflictPicker.vue
https://github.com/nextcloud-libraries/nextcloud-dialogs/blob/6dc168e5b1a3dc408f5ec290b9adc32d6753df7c/lib/components/ConflictPicker/ConflictPicker.vue#L334
https://github.com/nextcloud-libraries/nextcloud-dialogs/blob/6dc168e5b1a3dc408f5ec290b9adc32d6753df7c/lib/components/ConflictPicker/ConflictPicker.vue#L401
and in ConflictPickerCard.vue
https://github.com/nextcloud-libraries/nextcloud-dialogs/blob/6dc168e5b1a3dc408f5ec290b9adc32d6753df7c/lib/components/ConflictPicker/ConflictPickerCard.vue#L96
https://github.com/nextcloud-libraries/nextcloud-dialogs/blob/6dc168e5b1a3dc408f5ec290b9adc32d6753df7c/lib/components/ConflictPicker/ConflictPickerCard.vue#L134
cause stray ":deep" relicts in the output asses (e.g. also in the latest stable release 7.5.0:
$ grep :deep node_modules/@nextcloud/dialogs/dist/style.css
._cardDescription_ysn65_30 :deep(time) {
._pickerSelectAll_108fg_35._conflict-picker__all_108fg_50 :deep(label) {
I think there is missing the "scoped" attribute in the respective style start tags.
- Dominant language
- TypeScript
- Stars
- 19
- Forks
- 8
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 46
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nextcloud-libraries/nextcloud-dialogs
-
Actions on ToastsOpen
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
nextcloud-libraries/nextcloud-dialogs#2669 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
nextcloud-libraries/nextcloud-dialogs#2510 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
nextcloud-libraries/nextcloud-dialogs#2491 · 3 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
nextcloud-libraries/nextcloud-dialogs#2299 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
nextcloud-libraries/nextcloud-dialogs#2203 ·
Maintainers usually reply within 1 day
All issues in nextcloud-libraries/nextcloud-dialogs
Similar issues
-
e2e-failure ready-to-code
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
redhat-developer/rhdh-plugin-export-overlays#4391 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
Luligu/matterbridge#655 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
software-mansion/argent#1457 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
schmayterling/hibi#245 ·
Maintainers usually reply within 1 day
-
ai-driven-qa bug claude Minor
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
linagora/twake-contacts-frontend#241 ·
Maintainers usually reply within 1 day