fix(next/image): preserve deprecated prop annotations on Image
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #4177 by @MumuTW — merged
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- next.js, typescript, vite
- Domain
- frontend
Research direction
Find vinext’s next/image type definition and compare its ImageProps declaration with the upstream commit linked in the issue. Update the type surface to preserve inherited @deprecated annotations, then check that the editor or TypeScript reports those annotations for image attributes used through next/image.
Written by the indexing model from the issue text.
Description
Upstream commit: https://github.com/vercel/next.js/commit/af44b74d0c948c619330b23dfd3c748657655f11
Next.js changed ImageProps from an Omit<...> & { ... } type alias to an interface extending the same omitted intrinsic image props. This lets TypeScript surface @deprecated annotations inherited from image attributes to users of next/image.
Update vinext's next/image type surface to preserve this editor/type-checker behavior.
- Dominant language
- TypeScript
- Stars
- 9.2k
- Forks
- 449
- Avg merge
- 22h 16m
- Merged PRs (30d)
- 470
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cloudflare/vinext
-
The `next-js` export condition isn't set, so packages like next-sanity load their non-Next buildPossibly taken @james-elicx claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
cloudflare/vinext#4302 · 1 comment ·
Maintainers usually reply within 1 day
-
Fetch cache isn't bypassed in draft modePossibly taken @james-elicx claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
cloudflare/vinext#4301 · 1 comment ·
Maintainers usually reply within 1 day
-
[nextjs-tracker] Fix navigation from global-not-found to app routesPossibly taken @kanchingyg claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
cloudflare/vinext#4233 ·
Maintainers usually reply within 1 day
-
nextjs-tracking
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
cloudflare/vinext#3920 ·
Maintainers usually reply within 1 day
-
docs: document deployment with Cloudflare Workers Builds / Git integrationPossibly taken @reginaldalfret claimed this 19 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
cloudflare/vinext#3738 ·
Maintainers usually reply within 1 day
All issues in cloudflare/vinext
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
awslabs/visual-asset-management-system#804 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
restatedev/sdk-typescript#813 ·
-
bug desktop P1 session XS
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Merit-Systems/x402scan#1312 ·
-
type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Azure/apiops-cli#331 ·
Maintainers usually reply within 3 days