Dropped resource-updated notifications are never logged
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 86/100
Research direction
Start at the FeatureNotificationService entry point and inspect the fallback used when a resource-updated notification has no subscription. Change the fallback as specified, then run the relevant notification tests and verify that the "No subscription for resource … Skipping notification" message is logged.
Written by the indexing model from the issue text.
Description
In FeatureNotificationService, the fallback ?: { logger.info { … } } evaluates to a lambda that is never invoked. A resource-updated notification without a subscription is therefore dropped without the intended "No subscription for resource … Skipping notification" log line.
Expected: use ?: run { … }.
- Dominant language
- Kotlin
- Stars
- 1.5k
- Forks
- 262
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 46
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from modelcontextprotocol/kotlin-sdk
-
Client.connect does not apply the negotiated protocol version to Streamable HTTP transportPossibly taken @xu-baolin claimed this 27 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
modelcontextprotocol/kotlin-sdk#1090 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
modelcontextprotocol/kotlin-sdk#1088 ·
Maintainers usually reply within 1 day
-
An empty URI matches a single-variable resource templatePossibly taken @liyifan9642-creator claimed this 15 days ago. Openbug P3
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
modelcontextprotocol/kotlin-sdk#1085 ·
Maintainers usually reply within 1 day
-
AbstractClientTransport.checkState builds a broken error messagePossibly taken @mvanhorn claimed this 8 days ago. Openapi bug P3
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
modelcontextprotocol/kotlin-sdk#1083 · 1 comment ·
Maintainers usually reply within 1 day
-
bug P3
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
modelcontextprotocol/kotlin-sdk#1081 ·
Maintainers usually reply within 1 day
All issues in modelcontextprotocol/kotlin-sdk
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
PixelPlayerHQ/PixelPlayerOSS#193 ·
Maintainers usually reply within 1 day
-
bug web-server
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
jooby-project/jooby#4035 ·
Maintainers usually reply within 1 day
-
Android: theme prop is ignored in R8-minified release builds (Theme enum is not Enumerable)Possibly taken @1kuko3 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
keiyoushi/extensions-source#20494 · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100