AbstractClientTransport.checkState builds a broken error message
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- kotlin
- Domain
- backend-api-design
Research direction
Start by locating AbstractClientTransport.checkState and read the surrounding transport API, then review issue #1038 because the payload leaves fixing the call versus removing the protected method open. Done means the exception text uses the actual state and the ABI/API decision is consistent with that review.
Written by the indexing model from the issue text.
Description
AbstractClientTransport.checkState calls check(actualState == expected) { lazyMessage }. That returns the lambda itself instead of lazyMessage(actualState), so the exception text is a function's toString(). Nothing in the SDK calls the method, but it is protected API in the ABI dump, so subclasses can.
Expected: fix the call, or remove the method while the public API is being reviewed (#1038).
- Dominant language
- Kotlin
- Stars
- 1.5k
- Forks
- 261
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 36
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from modelcontextprotocol/kotlin-sdk
-
Client.connect does not apply the negotiated protocol version to Streamable HTTP transportPossibly taken @xu-baolin claimed this 24 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
modelcontextprotocol/kotlin-sdk#1090 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
modelcontextprotocol/kotlin-sdk#1088 ·
Maintainers usually reply within 1 day
-
An empty URI matches a single-variable resource templatePossibly taken @liyifan9642-creator claimed this 12 days ago. Openbug P3
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
modelcontextprotocol/kotlin-sdk#1085 ·
Maintainers usually reply within 1 day
-
Dropped resource-updated notifications are never loggedPossibly taken @leeshengis claimed this 18 days ago. Openbug P3
Difficulty 1/5 Under an hour Newbie friendliness 86/100
modelcontextprotocol/kotlin-sdk#1082 ·
Maintainers usually reply within 1 day
-
bug P3
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
modelcontextprotocol/kotlin-sdk#1081 ·
Maintainers usually reply within 1 day
All issues in modelcontextprotocol/kotlin-sdk
Similar issues
-
[Request] 李跳跳Openrequest-adaption
Difficulty 2/5 Under an hour Newbie friendliness 78/100
BetterAndroid/android-notification-icon-project#799 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
ProdigyV21/ARVIO#832 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
SIGSEGV in symex on __builtin_constant_p of a void expressionPossibly taken A pull request linked to this issue is open or already merged. Openbug goto-symex
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day