server: don't allow to set wrong maxRequestSize
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Start in ServerOptions (server module) and find the setter for maxRequestSize; it currently stores the value without validation. Add a check that rejects zero and negative values (match how other positive-only options in the same class validate and what exception they throw), then add or extend the options unit test to cover 0 and -1. Done when the fluent setter throws for non-positive input and the existing server options tests pass.
Written by the indexing model from the issue text.
Description
It must be always a positive number. Today it is allowed to set 0 or -1
var serverOptions = new ServerOptions()
.setMaxRequestSize(-1);
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 207
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 19
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from jooby-project/jooby
-
jetty: `form` method incorrectly merges query string and form urlencoded/multipart body parametersOpenbug jetty
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
jooby-project/jooby#4033 ·
Maintainers usually reply within 1 day
-
Reading body() before or after form() is not consistent across all serversPossibly taken @jknack claimed this 1 day ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 48/100
jooby-project/jooby#4031 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
jooby-project/jooby#4021 · 5 comments ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
jooby-project/jooby#3766 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
jooby-project/jooby#3521 · 2 comments ·
Maintainers usually reply within 1 day
All issues in jooby-project/jooby
Similar issues
-
priority: p2 type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
googleapis/java-genai#1372 ·
Maintainers usually reply within 1 day
-
GeoSeries scale and skew tests fail with pytest 9.2.0Possibly taken @jiayuasu claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
priority: medium Review effort [1-5]: 3 status: needs-triage type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
carlos-emr/carlos#5431 ·
Maintainers usually reply within 1 day
-
Integration tests: jetty:run fails with WELD-001408 for CountryJpaServicePossibly taken @viniciusmachak claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
primefaces/primefaces#15431 ·
Maintainers usually reply within 1 day
-
test(multi-tenancy): assert cross-tenant vulnerability reads are refused in the CWE isolation testOpen
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
OpenAEV-Platform/openaev#8792 ·
Maintainers usually reply within 2 days