SEP: which severity decides blocking when `valid`, `severity` and `messages[].severity` disagree?
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 15/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Domain
- backend-api-design
Research direction
Start with the SEP sections at docs/sep.md lines 336-342, 784, 825-826 and 1310, then read the three current rules: csharp/sdk/src/ModelContextProtocol.Interceptors/Client/InterceptorChainOrchestrator.cs, go/sdk/interceptors/chain/chain.go, and the Python path landed in #30. The deliverable is a decision, not a patch: one stated rule for which signal decides blocking, what a severity-less invalid result does, and whether the summary is counted by the same rule, recorded in the SEP and then applied in all three SDKs with tests mirroring the four-row table. Expect working-group discussion on the issue first; #45 must be updated to match whatever is chosen.
Written by the indexing model from the issue text.
Description
A ValidationResult carries three signals that can disagree: valid, the top-level severity, and a severity on each entry in messages (interface). The SEP says that only severity: "error" blocks (summary, key semantics) and that the invoker rejects "if any has severity: error" (error handling). It does not say which of the signals decides, and the three SDKs each chose a different rule.
- C# blocks when
validis false and the top-levelseverityiserror(InterceptorChainOrchestrator.cs). Message severities are only counted. - Go blocks when
validis false and some message has severityerror(chain.go). The top-levelseverityis not consulted. - Python (#30) uses the top-level
severitywhen present, otherwise the messages, and blocks an invalid result that carries no severity at all.
The same result therefore gets different verdicts:
| Result | C# | Go | Python (#30) |
|---|---|---|---|
valid: false, severity: "error", no messages |
blocks | passes | blocks |
valid: false, no severity, one error message |
passes | blocks | blocks |
valid: false, severity: "warn", one error message |
passes | blocks | passes |
valid: false, no severity, no messages |
passes | passes | blocks |
The C# and Go columns come from reading the code linked above. In the Python column, the third row was run and the fourth is covered by a test in #30; the first two come from reading the code.
Questions for the WG.
- Which signal decides blocking: the top-level
severity, any message, or either? - Does
valid: falsewith no severity anywhere block (fail-secure) or pass? - Is
valid: truewithseverity: "error"malformed, or simply non-blocking? - Should the validation summary be counted by the same rule as the verdict, so that a result cannot report an error and still pass?
#45 depends on the answer: it describes valid: false with severity: "error" as "an ordinary blocking error", which holds in C# and Python today but not in Go unless a message also carries error.
Found while reviewing #30.
🤖 Generated with Claude Code
- Dominant language
- C#
- Stars
- 24
- Forks
- 16
- Avg merge
- 3m
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from modelcontextprotocol/experimental-ext-interceptors
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
SEP: say whether `durationMs` and `timeoutMs` are integers; SDKs disagree and do not interoperateOpen
Difficulty 3/5 Half a day Newbie friendliness 35/100
-
Python SDK: support `phase="both"` as decorator sugarMay be free again @olaservo claimed this 101 days ago, and no pull request is open. Openenhancement
modelcontextprotocol/experimental-ext-interceptors#37 · 1 assignee ·
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
modelcontextprotocol/experimental-ext-interceptors#29 · 2 comments ·
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
modelcontextprotocol/experimental-ext-interceptors#20 · 1 comment ·
All issues in modelcontextprotocol/experimental-ext-interceptors
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
fluentmigrator/fluentmigrator#2460 ·
Maintainers usually reply within 1 day
-
hand-to-AI
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
CactuseSecurity/firewall-orchestrator#5803 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 3 days
-
bug python
Difficulty 1/5 Under an hour Newbie friendliness 88/100
ilia-sokolov/OfficeAgent.NET#89 ·
Maintainers usually reply within 13 days