SEP: which severity decides blocking when `valid`, `severity` and `messages[].severity` disagree?
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 15/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Área
- backend-api-design
Línea de trabajo
Start with the SEP sections at docs/sep.md lines 336-342, 784, 825-826 and 1310, then read the three current rules: csharp/sdk/src/ModelContextProtocol.Interceptors/Client/InterceptorChainOrchestrator.cs, go/sdk/interceptors/chain/chain.go, and the Python path landed in #30. The deliverable is a decision, not a patch: one stated rule for which signal decides blocking, what a severity-less invalid result does, and whether the summary is counted by the same rule, recorded in the SEP and then applied in all three SDKs with tests mirroring the four-row table. Expect working-group discussion on the issue first; #45 must be updated to match whatever is chosen.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
A ValidationResult carries three signals that can disagree: valid, the top-level severity, and a severity on each entry in messages (interface). The SEP says that only severity: "error" blocks (summary, key semantics) and that the invoker rejects "if any has severity: error" (error handling). It does not say which of the signals decides, and the three SDKs each chose a different rule.
- C# blocks when
validis false and the top-levelseverityiserror(InterceptorChainOrchestrator.cs). Message severities are only counted. - Go blocks when
validis false and some message has severityerror(chain.go). The top-levelseverityis not consulted. - Python (#30) uses the top-level
severitywhen present, otherwise the messages, and blocks an invalid result that carries no severity at all.
The same result therefore gets different verdicts:
| Result | C# | Go | Python (#30) |
|---|---|---|---|
valid: false, severity: "error", no messages |
blocks | passes | blocks |
valid: false, no severity, one error message |
passes | blocks | blocks |
valid: false, severity: "warn", one error message |
passes | blocks | passes |
valid: false, no severity, no messages |
passes | passes | blocks |
The C# and Go columns come from reading the code linked above. In the Python column, the third row was run and the fourth is covered by a test in #30; the first two come from reading the code.
Questions for the WG.
- Which signal decides blocking: the top-level
severity, any message, or either? - Does
valid: falsewith no severity anywhere block (fail-secure) or pass? - Is
valid: truewithseverity: "error"malformed, or simply non-blocking? - Should the validation summary be counted by the same rule as the verdict, so that a result cannot report an error and still pass?
#45 depends on the answer: it describes valid: false with severity: "error" as "an ordinary blocking error", which holds in C# and Python today but not in Go unless a message also carries error.
Found while reviewing #30.
🤖 Generated with Claude Code
- Lenguaje dominante
- C#
- Estrellas
- 24
- Forks
- 16
- Merge medio
- 3 min
- PR fusionados (30 d)
- 1
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de modelcontextprotocol/experimental-ext-interceptors
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
-
SEP: say whether `durationMs` and `timeoutMs` are integers; SDKs disagree and do not interoperateAbierto
Dificultad 3/5 Medio día Aptitud para principiantes 35/100
-
Python SDK: support `phase="both"` as decorator sugarQuizá libre de nuevo @olaservo la tomó hace 101 días y no hay ningún pull request abierto. Abiertoenhancement
modelcontextprotocol/experimental-ext-interceptors#37 · 1 asignado ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 42/100
modelcontextprotocol/experimental-ext-interceptors#29 · 2 comentarios ·
-
Conformance plan for InterceptorAbiertoenhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
modelcontextprotocol/experimental-ext-interceptors#20 · 1 comentario ·
Todos los issues de modelcontextprotocol/experimental-ext-interceptors
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
fluentmigrator/fluentmigrator#2460 ·
Los mantenedores suelen responder en 1 día
-
hand-to-AI
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
CactuseSecurity/firewall-orchestrator#5803 ·
Los mantenedores suelen responder en 1 día
-
Typed MINID rejects numeric thresholds with a leading plus sign accepted by Redis and ValkeyAbiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
Los mantenedores suelen responder en 1 día
-
DXF with empty names failsAbiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 3 días
-
bug python
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
ilia-sokolov/OfficeAgent.NET#89 ·
Los mantenedores suelen responder en 13 días