SEP: `interceptor/invoke` response examples omit the required `type`, `interceptor` and `phase` fields
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 85/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- documentation
Research direction
Open docs/sep.md: the required fields are defined in the ValidationResult and MutationResult interfaces around lines 327-355 and 379-391, while the two interceptor/invoke response examples are around lines 602-631 and 663-685. Compare each example against its interface and add the missing interceptor, type and phase fields to both. Done when the examples show the same required common fields as the interfaces; the C#, Python and Go SDK references in the issue explain why the mismatch matters.
Written by the indexing model from the issue text.
Description
The ValidationResult and MutationResult interfaces mark interceptor, type and phase as required (validation, mutation). The interceptor/invoke response examples leave all three out and show only the type-specific fields (validation response, mutation response).
Effect. An interceptor server written from the examples does not interoperate with invokers written from the interfaces:
- C# uses
typeas the polymorphic discriminator for the result (InterceptorResult.cs). - Python (#30) picks the result model from
typeand raises a validation error when it is missing.
Go is a third shape today: InvokeResult carries the common fields at the top level but nests the type-specific ones under validation / mutation (wire.go).
Proposal. Add interceptor, type and phase to both response examples so that they match the interfaces. If the intent is instead that these fields are optional on the wire, the interfaces should say so and invokers should fall back to the type declared in interceptors/list.
A shared response fixture in the conformance work (#20, #31) would keep the SDKs from drifting here again.
Found while reviewing #30.
🤖 Generated with Claude Code
- Dominant language
- C#
- Stars
- 24
- Forks
- 16
- Avg merge
- 3m
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from modelcontextprotocol/experimental-ext-interceptors
-
SEP: which severity decides blocking when `valid`, `severity` and `messages[].severity` disagree?Open
Difficulty 5/5 Over a week Newbie friendliness 15/100
-
SEP: say whether `durationMs` and `timeoutMs` are integers; SDKs disagree and do not interoperateOpen
Difficulty 3/5 Half a day Newbie friendliness 35/100
-
Python SDK: support `phase="both"` as decorator sugarMay be free again @olaservo claimed this 101 days ago, and no pull request is open. Openenhancement
modelcontextprotocol/experimental-ext-interceptors#37 · 1 assignee ·
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
modelcontextprotocol/experimental-ext-interceptors#29 · 2 comments ·
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
modelcontextprotocol/experimental-ext-interceptors#20 · 1 comment ·
All issues in modelcontextprotocol/experimental-ext-interceptors
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
fluentmigrator/fluentmigrator#2460 ·
Maintainers usually reply within 1 day
-
hand-to-AI
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
CactuseSecurity/firewall-orchestrator#5803 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 3 days
-
bug python
Difficulty 1/5 Under an hour Newbie friendliness 88/100
ilia-sokolov/OfficeAgent.NET#89 ·
Maintainers usually reply within 13 days