gpu-gates: chain FFN duplicates the shared U64 constant
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- Under an hour
- Newbie friendliness
- 82/100
Research direction
Start in crates/gpu-gates/src/bin/gate_deepseek41_chain_ffn.rs at line 183, where the local U64 is defined, and compare it with the public U64 in crates/gpu-gates/src/rounding.rs line 13. Check how the existing chain-glue gate imports the shared constant, then import rounding::U64 in the FFN gate. Done when the local definition and its comment are removed and the gate still builds and runs.
Written by the indexing model from the issue text.
Description
The chain FFN gate defines U64 as f64::EPSILON / 2.0 at crates/gpu-gates/src/bin/gate_deepseek41_chain_ffn.rs:183, duplicating the public U64 at crates/gpu-gates/src/rounding.rs:13. Both represent f64 unit roundoff, so this is the same fact with two owners (R14). Import rounding::U64 and remove the gate-local definition and its comment. The existing chain-glue gate already uses this shared owner. These definitions are unchanged by the PR; locations refer to the base tree.
Evidence (at the base of #276):
Filed by Shingler, the review bot, while reviewing #276; the defect is outside that pull request.
- Dominant language
- Rust
- Stars
- 21
- Forks
- 4
- Avg merge
- 3h 23m
- Merged PRs (30d)
- 248
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from midagedev/bloomery
-
review-bot
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
review-bot
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
nightly: failed git status still publishes an unqualified source commitPossibly taken A pull request linked to this issue is open or already merged. Openreview-bot
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Maintainers usually reply within 1 day
-
contrib-check: failed git status publishes a clean commit labelPossibly taken A pull request linked to this issue is open or already merged. Openreview-bot
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
review-bot
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
All issues in midagedev/bloomery
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
AimesSoft/NipaPlay-Reload#1022 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ZcashFoundation/frost-tools#612 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
ScoopInstaller/Extras#19070 ·
Maintainers usually reply within 1 day
-
test: sim_zero_omega_tests race on shared temp-file names, so two pairs of tests fail at randomOpen
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100