nightly: failed git status still publishes an unqualified source commit
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 79/100
Research direction
Start at the status assignment on line 128 of tools/nightly/run.sh and trace how its result affects the commit label and execution flow. Reproduce the case with NIGHTLY_NO_FETCH=1 and a readable HEAD but corrupt index; call finish 2 RED with the tree and Git exit code before publishing the source commit. Done when the run stops with that failure instead of publishing an unqualified commit or continuing into units.
Written by the indexing model from the issue text.
Description
With NIGHTLY_NO_FETCH=1, a repository with a readable HEAD and a corrupt index passes the clone-directory check. git status exits 128 with no stdout, but the -n test discards that failure. The commit file and summary receive HEAD without +local, and execution continues into the units. Isolated execution of the cited production line with Git exit 128 confirms the unchanged label and continued execution. Check the status assignment and call finish 2 RED with the tree and Git exit code before publishing the source commit.
Evidence (at the base of #379):
Filed by Shingler, the review bot, while reviewing #379; the defect is outside that pull request.
- Dominant language
- Rust
- Stars
- 21
- Forks
- 4
- Avg merge
- 2h 32m
- Merged PRs (30d)
- 823
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from midagedev/bloomery
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
midagedev/bloomery#1157 · 1 comment ·
Maintainers usually reply within 1 day
-
good first issue hardware help wanted no-box serve
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
good first issue hardware help wanted no-box
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
midagedev/bloomery#863 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
Maintainers usually reply within 1 day
All issues in midagedev/bloomery
Similar issues
-
auto:producer auto:security
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
fritzprix/libr-agent#2595 ·
Maintainers usually reply within 1 day
-
area:fs type:fix
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Tripstack-Corp/spyc#1002 ·
Maintainers usually reply within 1 day
-
github_actions security
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
dekobon/big-code-analysis#1815 ·
Maintainers usually reply within 1 day
-
[Detail Bug] Request logs can be forged via control characters in fetch object keys (log injection)Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
s2-streamstore/cachey#211 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day