contrib-check: failed git status publishes a clean commit label
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 84/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- bash, git
- Domain
- tooling
Research direction
Read tools/contrib-check.sh around line 209, where the script checks Git status and prints the evidence header. Reproduce the failure with a readable HEAD and corrupt index, then check that the script reports the tree and Git exit code and stops before the header; a successful run should still label evidence with +local when the tree is dirty.
Written by the indexing model from the issue text.
Description
A tree with a readable HEAD and a corrupt index reaches the evidence header. git status exits 128 with no stdout, but the -n test discards that failure and the header prints HEAD without +local. A run restricted to fmt can still succeed and attribute its evidence to that commit. Isolated execution of the cited production line with Git exit 128 confirms the unchanged label and continued execution. Capture and check the status assignment, report the tree and Git exit code, and stop before printing the evidence header on failure.
Evidence (at the base of #379):
Filed by Shingler, the review bot, while reviewing #379; the defect is outside that pull request.
- Dominant language
- Rust
- Stars
- 21
- Forks
- 4
- Avg merge
- 2h 32m
- Merged PRs (30d)
- 803
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from midagedev/bloomery
-
good first issue hardware help wanted no-box serve
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
good first issue hardware help wanted no-box
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 8/100
midagedev/bloomery#1133 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 1-2 days Newbie friendliness 8/100
midagedev/bloomery#1124 · 1 comment ·
Maintainers usually reply within 1 day
All issues in midagedev/bloomery
Similar issues
-
docs(metrics): replace stale src/metrics.rs line anchors in dashboard-metrics.md with symbol namesOpen
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
ci-cd desktop size:low telemetry-improvement telemetry-round-1
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
vfarcic/dot-agent-deck#2079 ·
Maintainers usually reply within 1 day
-
修改文件名时主键盘上的数字无法输入Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
qingjian-team/qingjian#894 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
rubys/roundhouse#1757 ·
-
enhancement user-priority/P3
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day