[Feature] Avoid duplicate error notifications
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript, typescript
Research direction
Look for the Install Pods command implementation, likely in a file handling CocoaPods version checking. Identify the nested try-catch blocks. The inner catch should only wrap and rethrow the error, removing its own logging/notification. Add a test to ensure the error is shown only once. Check existing test files for similar error handling tests.
Written by the indexing model from the issue text.
Description
Description
When the Install Pods command fails while checking the CocoaPods version, the error is displayed twice.
The inner catch block logs and displays the error, then rethrows it to the outer catch, which logs and displays it again.
Expected behavior
The inner catch should add context and rethrow the error. Error logging and user notification should be handled once by the outer catch.
Proposed fix
- Remove logging and notification from the inner
catch. - Preserve the original error details when rethrowing.
- Add a regression test verifying that the error is displayed only once.
- Dominant language
- TypeScript
- Stars
- 2.7k
- Forks
- 296
- Avg merge
- 9h 11m
- Merged PRs (30d)
- 30
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/vscode-react-native
-
[Feature] Stop Expo Go installation when Quick Pick is canceledPossibly taken @erenbati claimed this 7 days ago. Openenhancement
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
microsoft/vscode-react-native#2959 ·
Maintainers usually reply within 1 day
-
enhancement follow-up
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
microsoft/vscode-react-native#2951 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 72/100
microsoft/vscode-react-native#2957 ·
Maintainers usually reply within 1 day
-
enhancement follow-up
Difficulty 3/5 1-2 days Newbie friendliness 68/100
microsoft/vscode-react-native#2952 ·
Maintainers usually reply within 1 day
-
enhancement follow-up
Difficulty 5/5 Over a week Newbie friendliness 35/100
microsoft/vscode-react-native#2950 ·
Maintainers usually reply within 1 day
All issues in microsoft/vscode-react-native
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
szTheory/exifcleaner#383 ·
Maintainers usually reply within 1 day
-
needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
LucasSantana-Dev/Lucky#2637 ·
Maintainers usually reply within 1 day
-
good first issue type: bug
Difficulty 1/5 Under an hour Newbie friendliness 88/100
medusajs/medusa#17127 · 2 comments ·
Maintainers usually reply within 1 day
-
Desktop: SSH connect and forward budgets are fixed at 15 s with no override; slow links loop on boot failurePossibly taken @liuhao1024 claimed this today. Openbackend/ssh comp/desktop P2 type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
NousResearch/hermes-agent#132508 · 3 comments ·
Maintainers usually reply within 1 day
-
Show the error reference on the error pagePossibly taken A pull request linked to this issue is open or already merged. Openenhancement
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
tomjn/coilbox-hub#454 ·
Maintainers usually reply within 1 day