[Feature] Incorrect log message when Metro process termination fails
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- react-native, typescript, vscode
- Domain
- tooling
Research direction
Start at the Clean & Restart Packager command and inspect the Windows and Unix Metro process lookup and termination paths. Verify the lookup and termination errors are handled separately, warnings include the PID and original error, and cleanup and restart continue after a termination failure; run the existing project tests if available.
Written by the indexing model from the issue text.
Description
Description
When running Clean & Restart Packager, Metro process lookup and termination are handled in the same try/catch block on both Windows and Unix.
If taskkill or kill fails, for example due to insufficient permissions, the extension incorrectly logs:
No Metro process found on port ...
This hides the actual termination error.
Process lookup and termination should be handled separately:
- If no process is found, skip termination normally.
- If a process is found but termination fails, log a warning containing the PID and the original error.
- Continue the cleanup and restart workflow after the warning.
- Dominant language
- TypeScript
- Stars
- 2.7k
- Forks
- 295
- Avg merge
- 11h 17m
- Merged PRs (30d)
- 24
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/vscode-react-native
-
enhancement follow-up
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
microsoft/vscode-react-native#2951 ·
-
enhancement follow-up
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
microsoft/vscode-react-native#2945 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
microsoft/vscode-react-native#2933 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
microsoft/vscode-react-native#2929 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
microsoft/vscode-react-native#2914 ·
All issues in microsoft/vscode-react-native
Similar issues
-
comp/desktop P3 type/bug
Difficulty 1/5 Under an hour Newbie friendliness 92/100
NousResearch/hermes-agent#118866 ·
-
Browser Waiting for: Product Owner
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
getsentry/sentry-javascript#24577 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
agilepathway/label-checker#640 ·
-
Plugin stuck at "loading" on DSH 0.1.6-alpha.2 — turnTail list slot registration missing options.id Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
chrisparsons83/flexspotff#153 ·