Own-agent checks: reject the Actions bot id in admit.mjs and test the source label in pr-verify
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- github-actions, javascript, node.js
Research direction
Start with .github/scripts/intake-triage/admit.mjs around lines 274 and 295-298, where the rules validator and ownAgentIds accept positive integers, and compare against ACTIONS_BOT_ID at line 1101. Then read .github/scripts/pr-verify/resolve-pr.mjs around line 1008 and compare its source: label check with SOURCE_LABEL in admission and babysit_verify_evidence.py. Add tests for rejecting the Actions bot id and a malformed source: label, then run the relevant intake-triage and pr-verify test suites; done means both checks fail early while shipped rules admit and verify the same issues as before.
Written by the indexing model from the issue text.
Description
Summary
Two checks that #16999 added for own-agent issues are looser in one place than in the others that read the same rule.
.github/scripts/intake-triage/admit.mjs: the rules validator (line 274) andownAgentIds(lines 295 to 298) accept any positive integer inown-agents.identities, including the GitHub Actions bot id (ACTIONS_BOT_ID, line 1101), which the rules file's description and the module's comment say must never be listed. The Python merge gate drops that id. No admission can come from it today:apply-verdict.mjswrites nothing for an authorauthorTrustrefuses, and the shipped list is["lanes-app"]. This is hardening..github/scripts/pr-verify/resolve-pr.mjsline 1008 countssource:labels (sourceLabels(...).length === 1) but never tests the label againstSOURCE_LABEL, which admission (admit.mjs) and the merge gate (babysit_verify_evidence.py) both do. A malformedsource:label passes pr-verify and is refused at the merge gate, so the pull request stalls instead of failing early.
Evidence
- Lines read at d55250ec; the files are unchanged on main since.
- Found by a review of the byte-copied files in melodic-software/pr-pipeline-sandbox#387. Neither was seen in a live run.
Done when
- The rules validator and
ownAgentIdsreject the Actions bot id, with a test for each. - pr-verify tests the single
source:label against the same pattern admission uses, with a malformed-label test. - No change to which issues are admitted or verified under the shipped rules.
- Dominant language
- Shell
- Stars
- 22
- Forks
- 2
- Avg merge
- 1h 47m
- Merged PRs (30d)
- 942
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from melodic-software/claude-code-plugins
-
Difficulty 2/5 1-3 hours Newbie friendliness 71/100
melodic-software/claude-code-plugins#17364 · 4 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
melodic-software/claude-code-plugins#17039 · 7 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
melodic-software/claude-code-plugins#16931 · 3 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
melodic-software/claude-code-plugins#15498 · 3 comments ·
Maintainers usually reply within 1 day
-
session-flow: remove a delivered absence's away state so idle hook cost returns to the cheap pathPossibly taken @kyle-sexton claimed this today. Open
Difficulty 3/5 1-2 days Newbie friendliness 18/100
melodic-software/claude-code-plugins#17389 · 4 comments ·
Maintainers usually reply within 1 day
All issues in melodic-software/claude-code-plugins
Similar issues
-
application-issue
Difficulty 1/5 Under an hour Newbie friendliness 82/100
Installomator/Installomator#3657 · 1 comment ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
nekko-labs/nekko-agent#2998 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
kenzok8/openwrt-honk#35 ·
Maintainers usually reply within 1 day
-
bug severity:medium triage:confirmed triage:in-progress
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Cotal-AI/Cotal#7795 · 1 comment ·
Maintainers usually reply within 1 day