Feature Request: Improve Samba Configuration Management
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 64/100
Research direction
Start by reading the Dockerfile and the scripts that generate or load /etc/samba/smb.default and /etc/samba/smb.conf; the issue does not name those entry points. Check how Samba handles include directives and how the image is built. Done means the default configuration includes an optional /etc/samba/my-smb.conf while the existing defaults remain in place; verify with a mounted custom configuration.
Written by the indexing model from the issue text.
Description
The default configuration could automatically include an optional custom configuration file:
include = /etc/samba/my-smb.conf
Users would only need to mount their custom configuration:
volumes:
- ./my-smb.conf:/etc/samba/my-smb.conf
/etc/samba/
├── smb.default
├── smb.conf
└── my-smb.conf
The main benefit is separating common configuration from user-specific configuration.
The project should maintain common Samba settings and defaults, while users should only need to manage the settings they want to customize.
My current Dockerfile:
FROM dockurr/samba:latest
RUN sed -i '/^exec smbd/i \
if [ "${NMBD_ENABLE:-0}" = "1" ]; then\n\
echo "Starting nmbd..."\n\
nmbd --configfile="$config" --daemon\n\
fi\n' /usr/bin/samba.sh
RUN sed -i '/^\[global\]/a include = /etc/samba/my-smb.conf' /etc/samba/smb.default
RUN sed -i '/^\[Shared\]/,/^\[/ { /^\[Shared\]/d; /^\[/!d; }' /etc/samba/smb.default
- Dominant language
- Shell
- Stars
- 840
- Forks
- 64
- PR merge metrics
- No merged PRs in 30d
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dockur/samba
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Similar issues
-
application-issue
Difficulty 1/5 Under an hour Newbie friendliness 82/100
Installomator/Installomator#3657 · 1 comment ·
Maintainers usually reply within 3 days
-
Own-agent checks: reject the Actions bot id in admit.mjs and test the source label in pr-verifyOpen
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
melodic-software/claude-code-plugins#17374 · 2 comments ·
Maintainers usually reply within 1 day
-
out-of-date
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
CachyOS/CachyOS-PKGBUILDS#2154 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
eip-work/kuboard-press#723 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
nekko-labs/nekko-agent#2998 ·
Maintainers usually reply within 1 day