planning evals: reorder-points case expects a MEDIUM blast radius and no reviewer dispatch, which main's plan skill cannot both satisfy

Open Beginner friendly
#17,039 7 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
66/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
shell

Research direction

Read plugins/planning/skills/plan/SKILL.md under “Reviewer” and compare it with the two graders and fixture named in the issue. Then inspect sibling plan-reviewer-cut cases from #15465 for the same conflict. Update the case so both graders reflect main’s shipped rule, and verify that both pass in one run across three runs.

Written by the indexing model from the issue text.

Description

Problem

Two graders of the eval case plugins/planning/evals/plan-reviewer-cut-medium-reorder-points cannot both pass on main:

  • graders/blast-radius-medium.md requires the plan to rate the blast radius MEDIUM (pattern blast[ -]radius[^\n]{0,12}?\bMEDIUM\b).
  • graders/reviewer-not-dispatched.md requires that no plan-reviewer agent is dispatched (min: 0, max: 0, arm: both).
  • plugins/planning/skills/plan/SKILL.md ("Reviewer"): under auto the reviewer "runs when the Step 3b blast radius is MEDIUM or higher". The case's scaffold sets verification: standard (plugins/planning/evals/fixtures/plan-reviewer-cut/init-repo.sh), so a MEDIUM rating dispatches the reviewer.

Both graders came in #15465, written for a cut of the reviewer at MEDIUM. That cut did not ship: the reviewer stays on at MEDIUM until measured. In the run recorded for #16921, blast-radius-medium failed 3 of 3 runs and reviewer-not-dispatched passed 3 of 3. Each grader weighs 0.001, so no score moved, but the case's name no longer says what it exercises.

Options

  • (a) Drop max: 0 from reviewer-not-dispatched in this case, so it matches the shipped rule that MEDIUM runs the reviewer. Recommended (basis: plugins/planning/skills/plan/SKILL.md, "Reviewer").
  • (b) Retarget the case to LOW: rename it and change blast-radius-medium, if the scaffold's four changed files with a clean revert are meant to rate LOW (plugins/planning/skills/plan/context/stress-test-triggers.md rates 3 to 10 files MEDIUM and "Git revert works" lower).

Done when

  • Both graders can pass in one run on main's plan skill, and a run of 3 shows it.
  • The sibling plan-reviewer-cut cases from #15465 are checked for the same conflict.

Source: workshop 01 close-out audit.

Dominant language
Shell
Stars
22
Forks
2
Avg merge
1h 47m
Merged PRs (30d)
942

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from melodic-software/claude-code-plugins

All issues in melodic-software/claude-code-plugins

Similar issues

More Shell/Bash issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.