Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

About Ms3930 check conditions kind

Open
  • Is something wrong?
#824 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
go, rust
Domain
testing-qa

Research direction

Read tests/msc3930/msc3930_test.go at lines 43-55 and compare its event_match condition with ruma-common/src/push/predefined.rs at lines 290-302. Determine whether both condition kinds must be covered, then verify the resulting MSC3930 test behavior and add coverage for the confirmed interpretation.

Written by the indexing model from the issue text.

Description

https://github.com/matrix-org/complement/blob/65e78cd1d19a781d40bfd189b9d444d9814091ba/tests/msc3930/msc3930_test.go#L43C1-L55C4

Ms3930 check conditions type is event_match, but ruma seems use EventPropertyIs. Do we need to check both kind?

https://github.com/ruma/ruma/blob/a67081e402dce14365089b34f50489dacc9c53b5/crates/ruma-common/src/push/predefined.rs#L290C1-L302C6

Dominant language
Go
Stars
99
Forks
72
Avg merge
1d 4h
Merged PRs (30d)
8

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from matrix-org/complement

All issues in matrix-org/complement

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.