`TestRoomDeleteAlias` tests optional behaviour but fails if it is not performed
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Start in tests/csapi/apidoc_room_alias_test.go at the Can delete canonical alias test, lines 277-308. Review how the test observes the m.room.canonical_alias event through sync after deleting an alias. Done means the test passes or skips when the optional event update is absent, while still checking the update when it is provided.
Written by the indexing model from the issue text.
Description
The test Can delete canonical alias requires that servers update the m.room.canonical_alias event when an associated alias is deleted via DELETE /_matrix/client/v3/directory/room/{roomAlias}, but this behaviour is optional, and not even a SHOULD in the spec:
Note: Servers may choose to update the
alt_aliasesfor them.room.canonical_aliasstate event in the room when an alias is removed. Servers which choose to update the canonical alias event are recommended to, in addition to their other relevant permission checks, delete the alias and return a successful response even if the user does not have permission to update them.room.canonical_alias event.
This means the test will fail on any server that does not choose to implement this behaviour. The test should simply pass or at least be skipped if the canonical alias event update does not come down sync.
- Dominant language
- Go
- Stars
- 100
- Forks
- 72
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 8
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from matrix-org/complement
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
matrix-org/complement#901 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
matrix-org/complement#899 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 56/100
matrix-org/complement#898 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 62/100
matrix-org/complement#897 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
matrix-org/complement#824 ·
All issues in matrix-org/complement
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
enhancement needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
kind/cleanup
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
kubernetes-sigs/kueue#15947 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sympozium-ai/sympozium#627 ·
-
priority: p3
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
googleapis/librarian#7636 ·