Account deactivation tests depend on oneshot UIA

Open
#898 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
56/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
go
Domain
testing-qa

Research direction

Start with tests/csapi/account_deactivate_test.go around lines 110-121 and review related issue #893. Trace the account deactivation helper's UIA handling and identify the test expectations that depend on it; done means the helper no longer requires skipping UIA and the affected tests are no longer flaky.

Written by the indexing model from the issue text.

Description

Related: #893

https://github.com/matrix-org/complement/blob/1a2baac5dbf45ead46409793fe625b3c253eb4f6/tests/csapi/account_deactivate_test.go#L110-L121

The account deactivation helper requires being capable of skipping UIA, which is not spec compliant and causes flaky failures in all tests that use it.

Dominant language
Go
Stars
100
Forks
72
Avg merge
4d 1h
Merged PRs (30d)
8

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from matrix-org/complement

All issues in matrix-org/complement

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.