A small issue in render_annotation function
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 45/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- python
- Domain
- autonomous-driving, computer-vision
Research direction
Open lyft_dataset_sdk/lyftdataset.py around lines 1083-1086 and inspect the assertion that ensures boxes contains one item, then review how boxes[0] is passed to view_points. The refactor is done when render_annotation preserves its current output without iterating unnecessarily; verify it with the relevant rendering or dataset tests.
Written by the indexing model from the issue text.
Description
Hey,
In render_annotation function you don't need a for loop (here) as there will always be one box in boxes (we are doing assertion checks for the same). And you are passing boxes[0] to view_points within the loop anyways. (here)
And, this time I wanna fix this by raising a PR, do let me know if I can process with that :)
- Dominant language
- Jupyter Notebook
- Stars
- 390
- Forks
- 99
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lyft/nuscenes-devkit
-
Difficulty 1/5 Under an hour Newbie friendliness 20/100
lyft/nuscenes-devkit#106 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 20/100
lyft/nuscenes-devkit#105 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
lyft/nuscenes-devkit#104 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
lyft/nuscenes-devkit#103 · 2 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 48/100
lyft/nuscenes-devkit#99 ·
All issues in lyft/nuscenes-devkit
Similar issues
-
area:runtime good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
WATonomous/wato_f1tenth#39 ·
-
RingOutlierFilterComponent never sets row_step on its output PointCloud2 (always 0)Possibly taken @JArmandoAnaya claimed this 15 days ago. Open
Difficulty 1/5 1-3 hours Newbie friendliness 92/100
autowarefoundation/autoware_universe#13413 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Thinklab-SJTU/Bench2Drive#235 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
QwenLM/Qwen-Drive-1.0#7 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
autowarefoundation/vision_pilot#412 · 3 comments ·
Maintainers usually reply within 4 days