Sharing: send the answer directly on the same stack
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
Research direction
Start with SendAnswer in model/sharing/oauth.go and the /answer handler that calls ProcessAnswer. Compare the local and remote owner paths, preserving the credentials exchange and errors used by share-autoaccept retries. Add tests for local and remote owners, then check the fanout load test: when all members are on one stack, it should make no /answer HTTP calls.
Written by the indexing model from the issue text.
Description
When a recipient accepts, SendAnswer (model/sharing/oauth.go) sends POST /sharings/:id/answer to the owner, even when the owner is on the same stack. Under load, these answers get 409s (#5146).
- When the owner is on this stack (
LocalInstanceFromURL, from #4785), call itsProcessAnswerdirectly. The/answerhandler only callsProcessAnswer, so the checks stay the same. - Keep the credentials exchange as it is, so later calls still work.
- Return the same errors as the HTTP path, so the
share-autoacceptretries still work. Use HTTP only when the owner is not on this stack. - Tests: local owner, remote owner. In the fanout load test (#5235) with all members on one stack, no
/answerHTTP calls.
Size: ~200 lines. Depends on: nothing.
- Dominant language
- Go
- Stars
- 1.3k
- Forks
- 147
- Avg merge
- 22h 40m
- Merged PRs (30d)
- 134
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from linagora/cozy-stack
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
linagora/cozy-stack#5231 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
linagora/cozy-stack#5228 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
linagora/cozy-stack#5210 ·
Maintainers usually reply within 1 day
-
CSP: AppendCSPRule adds the sources to an earlier directive when the directive name appears in one of its sources (e.g. https://frame-src.example.com)Possibly taken A pull request linked to this issue is open or already merged. Openai-driven-fuzzing bug Minor
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
linagora/cozy-stack#5161 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
linagora/cozy-stack#5237 ·
Maintainers usually reply within 1 day
All issues in linagora/cozy-stack
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
coder/openstorage#807 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
coder/coder-logstream-kube#255 · 1 comment ·
-
[FEATURE]: 录入 AIDEV Agent Package v1 接入参考文档Possibly taken A pull request linked to this issue is open or already merged. Openkind/features
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
TencentBlueKing/bk-nodemgr#3991 ·
Maintainers usually reply within 1 day