coder-logstream-kube deployment naming conflict

Open Beginner friendly
#255 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
go, helm, kubernetes
Domain
devops, tooling

Research direction

Start by reading the commit linked in the issue to find how the deployment name is derived, then inspect the Helm chart templates and values for the existing configurable RBAC names. Add a configurable deployment name or nameOverride consistent with the chart's conventions. Done means templating coder and coder-logstream-kube together no longer produces two deployments named coder.

Written by the indexing model from the issue text.

Description

Hey, we are using a wrapper chart to deploy Coder and coder-logstream-kube. Therefore, the release name of both is coder, which leads to a conflict in the name of the deployment in the new version, as https://github.com/coder/coder-logstream-kube/commit/500d0d50c40e0b3d6ced56167bce80a49d76ad44 changed the name of the deployment to the name of the release. Would it be possible, to support something like a nameOverride in coder-logstream-kube, to prevent the naming conflict and keep the deployment of Coder itself as coder or make the name of the deployment configurable as for the RBAC resources?

To reproduce:

  1. Create a Helm chart with coder and coder-logstream-kube as dependency charts
  2. Deploy or template the chart -> leads to 2 deployment with the name coder
Dominant language
Go
Stars
28
Forks
9
Avg merge
7d 11h
Merged PRs (30d)
6

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from coder/coder-logstream-kube

All issues in coder/coder-logstream-kube

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.