api: a squash merge needs commit_message, and the default merge message follows upstream

Open Beginner friendly
#807 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
go
Domain
api

Research direction

Read the squash merge API handler and its tests, then check the referenced spec at 5d8e1801 for the exact HTTP status and problem code. Compare behavior for a squash merge with no commit_message and the default merge message against the documented requirements. Done when the missing-message case returns the documented error and the default message matches upstream; add or update tests for both.

Written by the indexing model from the issue text.

Description

Problem

Spec 5d8e1801: a squash merge requires commit_message, and the default merge commit message is Merge branch '<source>' into <target>. Live at 3af232d9: a squash merge without a message succeeded, and our default message is Merge mm into main.

Desk decision

Answer the documented 400 for a squash merge without commit_message (breaking for callers who omit it), and switch the default message to upstream's form. Check the spec for the exact status and problem code before coding.

Severity

Low.

Upstream audit 2026-11-12, evidence 2026-11-12-1159UTC. Docs spec 5d8e1801 (ETag W/"8GUlAlKU8eko7Rr2", Last-Modified 2026-11-10 22:29:59 GMT). The cluster still serves ee8092bf, so this is documented drift, not a proven deployment (#234 rule: adopt what the docs publish). SDK 0.1.1 (Nov 10) and 0.1.2 (Nov 11) shipped on npm, PyPI and Go; their route list and token minting are unchanged from 0.1.0.


Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: medium

Dominant language
Go
Stars
0
Forks
0
Avg merge
6h 16m
Merged PRs (30d)
243

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from coder/openstorage

All issues in coder/openstorage

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.