Out-of-bound access on controller device type list

Open
#857 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
c
Domain
game-dev

Research direction

The report gives a screenshot and an attached patch (0001-options-fix-out-of-bound-accesses-on-controller-devi.patch) rather than a file path, so start by reading that patch: it points at the loop that walks the controller device type option list. Reproduce the out-of-bound read in the core's input/options handling, apply the bounds fix, then confirm that enumerating controller device types no longer reads past the list. Done means the crash in the screenshot is gone and the option still lists the correct device types.

Written by the indexing model from the issue text.

Description

The title is pretty much self-explanatory. Evidence:

image

Tentative fix:

0001-options-fix-out-of-bound-accesses-on-controller-devi.patch

Dominant language
C
Stars
414
Forks
155
Avg merge
1d 8h
Merged PRs (30d)
4

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from libretro/parallel-n64

All issues in libretro/parallel-n64

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.