HTTP/1: HTTP/1.1 prefix is accepted as the complete request version
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- c
- Domain
- backend-api-design, security
Research direction
Start in src/net/http/http.c at the request-line parsing comparison around lines 4680–4697, then review the Host handling check around lines 4810–4815. Trace how the parsed version is used for keep-alive and add coverage for malformed version tokens such as HTTP/1.1junk. Done means unsupported or malformed request versions receive HTTP 400 while exact supported versions retain their behavior.
Written by the indexing model from the issue text.
Description
Confirmed on dev at fd8cf045770459ebc0f6b6740f54dcd30a80ce6c.
Request-version checks use strncmp(version, "HTTP/1.1", 8) == 0 rather than exact matching. As a result, versions such as HTTP/1.1junk are accepted as HTTP/1.1, including keep-alive behavior.
Sources:
- Prefix comparison in request-line parsing: https://github.com/c4punks/CWIST/blob/fd8cf045770459ebc0f6b6740f54dcd30a80ce6c/src/net/http/http.c#L4680-L4697
- The same prefix determines mandatory Host handling: https://github.com/c4punks/CWIST/blob/fd8cf045770459ebc0f6b6740f54dcd30a80ce6c/src/net/http/http.c#L4810-L4815
A public-parser repro accepted GET / HTTP/1.1junk and returned version_suffix=1.
Other HTTP agents will reject or classify this request differently, so accepting it creates another proxy differential. Require an exact supported version token and reject malformed request lines with HTTP 400.
- Dominant language
- C
- Stars
- 16
- Forks
- 7
- Avg merge
- 4h 54m
- Merged PRs (30d)
- 185
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from c4punks/CWIST
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
bug
Difficulty 4/5 1-2 days Newbie friendliness 58/100
Maintainers usually reply within 1 day
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 53/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
libretro/parallel-n64#858 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Mbed-TLS/TF-PSA-Crypto#984 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
tursodatabase/libsql#2320 ·
Maintainers usually reply within 11 days
-
type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day