C-buttons on standard mapping (R2+face buttons) do not work
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 65/100
Research direction
Start with the declarations and use of r_cbutton in libretro/libretro.c and mupen64plus-core/src/plugin/emulate_game_controller_via_libretro.c, then compare how Mupen64Plus initializes the corresponding values from core options in the linked libretro.c location. Check the standard mapping path and verify that all four C-button variables are initialized consistently; done when standard mapping no longer uses uninitialized values.
Written by the indexing model from the issue text.
Description
Root cause seems to be the respective variables in the code not being initialized.
This is only for standard mapping (i.e., does not seem to apply to independent C-buttons mapping). Taking the right C-button as an example:
parallel-n64$ git rev-parse @
e0ef5d673257e2e83bf9b7cffe62eda141af8493
parallel-n64$ git grep "r_cbutton"
libretro/libretro.c:int r_cbutton, l_cbutton, d_cbutton, u_cbutton;
mupen64plus-core/src/plugin/emulate_game_controller_via_libretro.c:extern int r_cbutton;
mupen64plus-core/src/plugin/emulate_game_controller_via_libretro.c: Keys->R_CBUTTON = !!((ret & (1 << r_cbutton)));
tools/test_mouse_accum.c:int r_cbutton, l_cbutton, d_cbutton, u_cbutton;
Mupen64Plus initializes the same values from core options:
Core options definitions: https://github.com/libretro/mupen64plus-libretro-nx/blob/15bada85906593376e8fd697f1b0b3af3a20f512/libretro/libretro_core_options.h#L1586
Initialization in libretro.c: https://github.com/libretro/mupen64plus-libretro-nx/blob/15bada85906593376e8fd697f1b0b3af3a20f512/libretro/libretro.c#L850
- Dominant language
- C
- Stars
- 414
- Forks
- 155
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 4
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from libretro/parallel-n64
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
libretro/parallel-n64#858 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
libretro/parallel-n64#857 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 54/100
libretro/parallel-n64#856 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
libretro/parallel-n64#854 · 3 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
libretro/parallel-n64#853 ·
All issues in libretro/parallel-n64
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Mbed-TLS/TF-PSA-Crypto#984 ·
Maintainers usually reply within 2 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
enhancement help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
area: test kind: bug preview-effort: small priority: low
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Maintainers usually reply within 1 day