Beacon events report `execution_optimistic: false` for every gloas head and block
Maintainers usually reply within 6 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 56/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust
- Domain
- backend, distributed-systems
Research direction
Start with crates/net/rpc/src/shared/optimistic.rs to understand block_is_optimistic and envelope_is_optimistic, then inspect the event call sites in crates/blockchain/src/events.rs and the storage maps they read. Check how the helper can live in a crate shared by RPC and blockchain. Done means a gloas head whose parent payload is recorded as Syncing emits head and head_v2 with execution_optimistic: true, while pre-gloas behavior stays unchanged.
Written by the indexing model from the issue text.
Description
Problem. The head, head_v2, block and finalized_checkpoint events take execution_optimistic from Store::is_beacon_optimistic, i.e. the store's optimistic_roots set:
crates/blockchain/src/events.rs:806(block);events.rs:1162(head,head_v2,chain_reorg);events.rs:1249(the secondhead_v2);events.rs:1313(finalized_checkpoint).
Only pre-gloas blocks ever enter that set. beacon_engine::new_payload_request returns None for a gloas block (crates/blockchain/src/beacon_engine.rs:134), so its import is PayloadValidity::NotRequired, and fork_choice::on_block adds a root only on Optimistic (crates/blockchain/state_transition/src/beacon/fork_choice.rs:5198-5203). From gloas on, every one of these events therefore reports execution_optimistic: false, even when the chain rests on a payload the execution client answered SYNCING. A consumer that holds off on optimistic heads (lighthouse suppresses those head events) is told the head is validated when it is not.
The Beacon API responses already get this right. crates/net/rpc/src/shared/optimistic.rs has block_is_optimistic (line 113), which walks back to the latest FULL payload a block builds on and reads its recorded verdict, and envelope_is_optimistic (line 100). docs/rpc.md ("execution_optimistic under gloas") describes the rule.
Why not in lambdaclass/ethlambda#748. That PR fixed the one event it added whose verdict is in hand, execution_payload, by passing the import's own verdict in. The other topics predate it on main (head_v2 inherits head's value), and the fix needs the walk in shared/optimistic.rs, which lives in ethlambda-rpc, a crate ethlambda-blockchain cannot depend on.
Fix. Move payload_link, payload_is_not_valid, block_is_optimistic and envelope_is_optimistic down to a crate both can use (ethlambda-storage, next to the maps they read, or ethlambda-state-transition), and have the events call block_is_optimistic where they now call is_beacon_optimistic. Pre-gloas results are unchanged, since the walk reads the optimistic set for a pre-gloas block. A test: a gloas head whose parent payload is recorded Syncing emits head/head_v2 with execution_optimistic: true.
- Dominant language
- Rust
- Stars
- 86
- Forks
- 34
- Avg merge
- 9d 20h
- Merged PRs (30d)
- 77
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lambdaclass/ethlambda
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
lambdaclass/ethlambda#850 ·
Maintainers usually reply within 6 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
lambdaclass/ethlambda#777 · 1 reaction ·
Maintainers usually reply within 6 days
-
Run all gossip validation testsMay be free again @dicethedev claimed this 9 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
lambdaclass/ethlambda#725 · 2 comments ·
Maintainers usually reply within 6 days
-
Handle malformed DB dataMay be free again @dicethedev claimed this 115 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
lambdaclass/ethlambda#529 · 4 comments ·
Maintainers usually reply within 6 days
-
Document architectural choicesMay be free again @dicethedev claimed this 115 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
lambdaclass/ethlambda#521 · 2 comments ·
Maintainers usually reply within 6 days
All issues in lambdaclass/ethlambda
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
antithesishq/bombadil#473 ·
Maintainers usually reply within 2 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
libracoder/kiri#669 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 5 days
-
autofixer: follow-up
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
tursodatabase/turso#12217 ·
Maintainers usually reply within 1 day
-
Declare the CMS schema library in the optional recipients extraPossibly taken A pull request linked to this issue is open or already merged. Openarea:python in-progress
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
yhay81/pyropdf#1005 · 2 comments ·
Maintainers usually reply within 1 day