Beacon events report `execution_optimistic: false` for every gloas head and block
维护者通常 6 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 56/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- rust
调研方向
Start with crates/net/rpc/src/shared/optimistic.rs to understand block_is_optimistic and envelope_is_optimistic, then inspect the event call sites in crates/blockchain/src/events.rs and the storage maps they read. Check how the helper can live in a crate shared by RPC and blockchain. Done means a gloas head whose parent payload is recorded as Syncing emits head and head_v2 with execution_optimistic: true, while pre-gloas behavior stays unchanged.
由索引模型根据 Issue 内容生成。
描述
Problem. The head, head_v2, block and finalized_checkpoint events take execution_optimistic from Store::is_beacon_optimistic, i.e. the store's optimistic_roots set:
crates/blockchain/src/events.rs:806(block);events.rs:1162(head,head_v2,chain_reorg);events.rs:1249(the secondhead_v2);events.rs:1313(finalized_checkpoint).
Only pre-gloas blocks ever enter that set. beacon_engine::new_payload_request returns None for a gloas block (crates/blockchain/src/beacon_engine.rs:134), so its import is PayloadValidity::NotRequired, and fork_choice::on_block adds a root only on Optimistic (crates/blockchain/state_transition/src/beacon/fork_choice.rs:5198-5203). From gloas on, every one of these events therefore reports execution_optimistic: false, even when the chain rests on a payload the execution client answered SYNCING. A consumer that holds off on optimistic heads (lighthouse suppresses those head events) is told the head is validated when it is not.
The Beacon API responses already get this right. crates/net/rpc/src/shared/optimistic.rs has block_is_optimistic (line 113), which walks back to the latest FULL payload a block builds on and reads its recorded verdict, and envelope_is_optimistic (line 100). docs/rpc.md ("execution_optimistic under gloas") describes the rule.
Why not in lambdaclass/ethlambda#748. That PR fixed the one event it added whose verdict is in hand, execution_payload, by passing the import's own verdict in. The other topics predate it on main (head_v2 inherits head's value), and the fix needs the walk in shared/optimistic.rs, which lives in ethlambda-rpc, a crate ethlambda-blockchain cannot depend on.
Fix. Move payload_link, payload_is_not_valid, block_is_optimistic and envelope_is_optimistic down to a crate both can use (ethlambda-storage, next to the maps they read, or ethlambda-state-transition), and have the events call block_is_optimistic where they now call is_beacon_optimistic. Pre-gloas results are unchanged, since the walk reads the optimistic set for a pre-gloas block. A test: a gloas head whose parent payload is recorded Syncing emits head/head_v2 with execution_optimistic: true.
- 主要语言
- Rust
- 星标
- 86
- 派生
- 34
- 平均合并
- 9 天 20 小时
- 30 天内合并 PR
- 77
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
lambdaclass/ethlambda 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 76/100
lambdaclass/ethlambda#850 ·
维护者通常 6 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
lambdaclass/ethlambda#777 · 1 个 reaction ·
维护者通常 6 天内回复
-
Run all gossip validation tests可能重新可做 @dicethedev 于 9 天前认领,目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 62/100
lambdaclass/ethlambda#725 · 2 条评论 ·
维护者通常 6 天内回复
-
Handle malformed DB data可能重新可做 @dicethedev 于 115 天前认领,目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 76/100
lambdaclass/ethlambda#529 · 4 条评论 ·
维护者通常 6 天内回复
-
Document architectural choices可能重新可做 @dicethedev 于 115 天前认领,目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
lambdaclass/ethlambda#521 · 2 条评论 ·
维护者通常 6 天内回复
查看 lambdaclass/ethlambda 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 84/100
antithesishq/bombadil#473 ·
维护者通常 2 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 72/100
libracoder/kiri#669 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 88/100
维护者通常 5 天内回复
-
autofixer: follow-up
难度 2/5 1-3 小时 新手友好度 75/100
tursodatabase/turso#12217 ·
维护者通常 1 天内回复
-
Declare the CMS schema library in the optional recipients extra可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭area:python in-progress
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复