Bump the kurtosis battery's ethereum-package pin to a launcher that passes beacon --bootnodes as a list

Open Beginner friendly
#850 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 6 days

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
github-actions, rust

Research direction

Read .github/workflows/kurtosis_assertoor.yml around line 35 and compare its ETHEREUM_PACKAGE_REF with the specified add-ethlambda commit, 1aec42f3fdd934ef0520f535630fe86eec30cfe0. Update the pin to that commit or a later commit from the branch, then check that the battery workflow passes on the pull request; done means beacon startup accepts the bootnodes and the run succeeds.

Written by the indexing model from the issue text.

Description

lambdaclass/ethlambda#825 makes ethlambda beacon --bootnodes a comma-separated list of ENRs and multiaddrs, and refuses a file path at startup.

The kurtosis + assertoor battery still pins a launcher that passes a file:

  • .github/workflows/kurtosis_assertoor.yml:35 pins ETHEREUM_PACKAGE_REF: 67cb0e02dc0bd49ec9461cbf2ef7ac4a3232755f.
  • At that commit, src/cl/ethlambda/ethlambda_launcher.star in lambdaclass/ethereum-package writes the resolved bootnodes to /tmp/ethlambda-bootnodes.txt and passes --bootnodes=/tmp/ethlambda-bootnodes.txt (lines 17-19 and 173-186).

So once lambdaclass/ethlambda#825 is on main, the battery's push runs fail at beacon startup whenever the launcher has a bootnode to pass.

Why it is not in lambdaclass/ethlambda#825. On pull_request the workflow tests ghcr.io/lambdaclass/ethlambda:unstable, which is main's image, not the PR's. A pin bump inside lambdaclass/ethlambda#825 would trigger a run that pairs the list-passing launcher with a binary that still reads a file, and fail. The bump only makes sense once that PR is on main and in unstable.

Fix. Set ETHEREUM_PACKAGE_REF to 1aec42f3fdd934ef0520f535630fe86eec30cfe0, or a later commit of the fork's add-ethlambda branch (head today: 860b338622). That commit is "refactor: pass ethlambda's bootnodes as a comma-separated list", and it passes --bootnodes=<comma-joined ENRs> through cl_shared.append_bootnode_arg. It is 16 commits ahead of 67cb0e02 (the builder wiring, reporting ethlambda's ENR and TCP multiaddr, the image tag among them), so the battery run on the bump's own PR is what checks those against main.

Dominant language
Rust
Stars
86
Forks
34
Avg merge
9d 20h
Merged PRs (30d)
77

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from lambdaclass/ethlambda

All issues in lambdaclass/ethlambda

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.