Give the metrics server its own bind address
Maintainers usually reply within 6 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 53/100
Research direction
Start with the --http-address definition in bin/ethlambda/src/cli.rs:37-38 and start_http_servers in crates/net/rpc/src/lib.rs:118-138; then inspect Options::validate_ports and the RPC documentation. Add the separate metrics bind address with the stated default and address-aware port rule, then update the flag table and trust section in docs/rpc.md. The optional pprof flag is explicitly optional; done means the API and metrics servers can bind separately while existing setups keep working.
Written by the indexing model from the issue text.
Description
Problem. Both HTTP servers bind the one --http-address. The flag is defined at bin/ethlambda/src/cli.rs:37-38, and start_http_servers binds both servers to it at crates/net/rpc/src/lib.rs:118-138. So an operator whose Prometheus scrapes from another host has to move the API off loopback as well. That API is the one lambdaclass/ethlambda#778's "What the servers trust" section says must not be exposed, since anyone reaching it can:
- redirect fee recipients;
- join subnets;
- trigger payload builds.
The only thing left keeping the two apart is a per-port firewall rule. The metrics server also carries the jemalloc heap-profile endpoints (/debug/pprof/allocs), which a default Linux build serves.
Why it is out of scope. lambdaclass/ethlambda#778 is docs-only. It documents the shared address and does not change the CLI.
Fix. Add --metrics-address, defaulting to --http-address's value so existing setups keep working, and serve metrics_app on it in start_http_servers. Equal ports would then merge only when the two addresses are equal too, and Options::validate_ports would need the same rule. Optionally, put /debug/pprof/* behind an opt-in flag, so a scrape-only exposure does not also serve heap profiles. Update the flag table and the trust section in docs/rpc.md.
- Dominant language
- Rust
- Stars
- 86
- Forks
- 34
- Avg merge
- 9d 20h
- Merged PRs (30d)
- 77
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lambdaclass/ethlambda
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
lambdaclass/ethlambda#850 ·
Maintainers usually reply within 6 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
lambdaclass/ethlambda#777 · 1 reaction ·
Maintainers usually reply within 6 days
-
Run all gossip validation testsMay be free again @dicethedev claimed this 9 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
lambdaclass/ethlambda#725 · 2 comments ·
Maintainers usually reply within 6 days
-
Handle malformed DB dataMay be free again @dicethedev claimed this 115 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
lambdaclass/ethlambda#529 · 4 comments ·
Maintainers usually reply within 6 days
-
Document architectural choicesMay be free again @dicethedev claimed this 115 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
lambdaclass/ethlambda#521 · 2 comments ·
Maintainers usually reply within 6 days
All issues in lambdaclass/ethlambda
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
antithesishq/bombadil#473 ·
Maintainers usually reply within 2 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
libracoder/kiri#669 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 5 days
-
autofixer: follow-up
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
tursodatabase/turso#12217 ·
Maintainers usually reply within 1 day
-
Declare the CMS schema library in the optional recipients extraPossibly taken A pull request linked to this issue is open or already merged. Openarea:python in-progress
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
yhay81/pyropdf#1005 · 2 comments ·
Maintainers usually reply within 1 day