Give the metrics server its own bind address

Abierto
#817 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 6 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
53/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
rust
Área
api, backend

Línea de trabajo

Start with the --http-address definition in bin/ethlambda/src/cli.rs:37-38 and start_http_servers in crates/net/rpc/src/lib.rs:118-138; then inspect Options::validate_ports and the RPC documentation. Add the separate metrics bind address with the stated default and address-aware port rule, then update the flag table and trust section in docs/rpc.md. The optional pprof flag is explicitly optional; done means the API and metrics servers can bind separately while existing setups keep working.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem. Both HTTP servers bind the one --http-address. The flag is defined at bin/ethlambda/src/cli.rs:37-38, and start_http_servers binds both servers to it at crates/net/rpc/src/lib.rs:118-138. So an operator whose Prometheus scrapes from another host has to move the API off loopback as well. That API is the one lambdaclass/ethlambda#778's "What the servers trust" section says must not be exposed, since anyone reaching it can:

  • redirect fee recipients;
  • join subnets;
  • trigger payload builds.

The only thing left keeping the two apart is a per-port firewall rule. The metrics server also carries the jemalloc heap-profile endpoints (/debug/pprof/allocs), which a default Linux build serves.

Why it is out of scope. lambdaclass/ethlambda#778 is docs-only. It documents the shared address and does not change the CLI.

Fix. Add --metrics-address, defaulting to --http-address's value so existing setups keep working, and serve metrics_app on it in start_http_servers. Equal ports would then merge only when the two addresses are equal too, and Options::validate_ports would need the same rule. Optionally, put /debug/pprof/* behind an opt-in flag, so a scrape-only exposure does not also serve heap profiles. Update the flag table and the trust section in docs/rpc.md.

Lenguaje dominante
Rust
Estrellas
86
Forks
34
Merge medio
9 d 20 h
PR fusionados (30 d)
77

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de lambdaclass/ethlambda

Todos los issues de lambdaclass/ethlambda

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.