validator: test the client with a large number of validator keys

Open
#797 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 6 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
rust

Research direction

Start by reading secret_key_for in test_state and the MockBeaconNode setup, then look at the duty path in crates/validator/src/preferences.rs, the commit path in slashing_protection/file.rs, and the registration batching in registration.rs. The scale harness should run a few epochs at 1,000 and 10,000 keys and record per-slot duty time, slashing-protection write time, and the registration send size. Done means those numbers are reported for both key counts. The issue does not settle whether any code should change.

Written by the indexing model from the issue text.

Description

The validator client has only been run with a handful of keys. Nothing measures what it costs per slot, per epoch or at startup with thousands of them, which is where several of its designs would show it first.

This came up in the review of #707: PreferencesService takes its sent lock once per proposer duty instead of once per poll (crates/validator/src/preferences.rs). That is harmless at the few proposals an epoch holds, but it is one example of a per-key cost nobody has measured.

What grows with the number of keys

These are read from the code, not measured:

  • Startup. ValidatorStore::load decrypts the keystores one after another (keys/store.rs). With EIP-2335's default scrypt parameters each one takes a noticeable fraction of a second, so 10,000 keys could take a long time before the first duty.
  • Slashing protection. Each commit re-renders the whole interchange file with every key's record, then writes it durably: a temporary file, an fsync, a rename and a directory fsync (slashing_protection/file.rs write). A slot's attestations are batched into one commit, so the commit itself is one per slot rather than one per key. Its size still grows with the number of keys, and it sits in front of every attestation signature. time_slashing_protection_write already records how long it takes.
  • Builder registrations (fulu and earlier, with --builder-proposals).
    • The first epoch signs one BLS signature per key on the blocking pool, 64 per chunk.
    • Every epoch then sends every registration in batches of 500.
    • A per-slot keymanager change waits behind that send. Against a slow node, that is at most 12 s per 500 validators (registration.rs module doc).
  • Epoch refresh. validator_indices POSTs every loaded pubkey every epoch, and prepare_beacon_proposer sends one entry per resolved key.
  • Per-slot duties. Attestations, aggregation selection and sync committee messages are signed for every key with a duty in the slot.

Proposal

  • A scale test or benchmark. It would drive the services against MockBeaconNode with, for example, 1,000 and 10,000 keys over a few epochs.
    • The keys would use the small-integer secrets from test_state::secret_key_for, so no keystore has to be decrypted.
    • It would measure the duty path's time per slot, the slashing-protection write time, the registration send's length and memory.
  • A separate startup measurement with real scrypt keystores.
  • A devnet run with a large key set behind one validator client, to see the same costs against a real beacon node.
  • Decide from the numbers whether anything needs changing first: parallel keystore decryption, or an incremental slashing-protection store in place of rewriting the whole file every commit.
Dominant language
Rust
Stars
86
Forks
34
Avg merge
9d 20h
Merged PRs (30d)
77

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from lambdaclass/ethlambda

All issues in lambdaclass/ethlambda

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.