validator: test the client with a large number of validator keys
Maintainer antworten meist innerhalb von 6 Tagen
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 30/100
- Issue-Typ
- Feature
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- rust
- Bereich
- performance, testing
Rechercherichtung
Start by reading secret_key_for in test_state and the MockBeaconNode setup, then look at the duty path in crates/validator/src/preferences.rs, the commit path in slashing_protection/file.rs, and the registration batching in registration.rs. The scale harness should run a few epochs at 1,000 and 10,000 keys and record per-slot duty time, slashing-protection write time, and the registration send size. Done means those numbers are reported for both key counts. The issue does not settle whether any code should change.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
The validator client has only been run with a handful of keys. Nothing measures what it costs per slot, per epoch or at startup with thousands of them, which is where several of its designs would show it first.
This came up in the review of #707: PreferencesService takes its sent lock once per proposer duty instead of once per poll (crates/validator/src/preferences.rs). That is harmless at the few proposals an epoch holds, but it is one example of a per-key cost nobody has measured.
What grows with the number of keys
These are read from the code, not measured:
- Startup.
ValidatorStore::loaddecrypts the keystores one after another (keys/store.rs). With EIP-2335's default scrypt parameters each one takes a noticeable fraction of a second, so 10,000 keys could take a long time before the first duty. - Slashing protection. Each
commitre-renders the whole interchange file with every key's record, then writes it durably: a temporary file, an fsync, a rename and a directory fsync (slashing_protection/file.rswrite). A slot's attestations are batched into one commit, so the commit itself is one per slot rather than one per key. Its size still grows with the number of keys, and it sits in front of every attestation signature.time_slashing_protection_writealready records how long it takes. - Builder registrations (fulu and earlier, with
--builder-proposals).- The first epoch signs one BLS signature per key on the blocking pool, 64 per chunk.
- Every epoch then sends every registration in batches of 500.
- A per-slot keymanager change waits behind that send. Against a slow node, that is at most 12 s per 500 validators (
registration.rsmodule doc).
- Epoch refresh.
validator_indicesPOSTs every loaded pubkey every epoch, andprepare_beacon_proposersends one entry per resolved key. - Per-slot duties. Attestations, aggregation selection and sync committee messages are signed for every key with a duty in the slot.
Proposal
- A scale test or benchmark. It would drive the services against
MockBeaconNodewith, for example, 1,000 and 10,000 keys over a few epochs.- The keys would use the small-integer secrets from
test_state::secret_key_for, so no keystore has to be decrypted. - It would measure the duty path's time per slot, the slashing-protection write time, the registration send's length and memory.
- The keys would use the small-integer secrets from
- A separate startup measurement with real scrypt keystores.
- A devnet run with a large key set behind one validator client, to see the same costs against a real beacon node.
- Decide from the numbers whether anything needs changing first: parallel keystore decryption, or an incremental slashing-protection store in place of rewriting the whole file every commit.
- Vorherrschende Sprache
- Rust
- Sterne
- 86
- Forks
- 34
- Ø Merge
- 9 T. 20 Std.
- Gemergte PRs (30 T.)
- 77
Entwicklungsumgebung
- Enthält ein Dockerfile oder eine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus lambdaclass/ethlambda
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
lambdaclass/ethlambda#850 ·
Maintainer antworten meist innerhalb von 6 Tagen
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
lambdaclass/ethlambda#777 · 1 Reaktion ·
Maintainer antworten meist innerhalb von 6 Tagen
-
Run all gossip validation testsEvtl. wieder frei @dicethedev hat das vor 9 Tagen übernommen, und es ist kein Pull Request offen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
lambdaclass/ethlambda#725 · 2 Kommentare ·
Maintainer antworten meist innerhalb von 6 Tagen
-
Handle malformed DB dataEvtl. wieder frei @dicethedev hat das vor 115 Tagen übernommen, und es ist kein Pull Request offen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
lambdaclass/ethlambda#529 · 4 Kommentare ·
Maintainer antworten meist innerhalb von 6 Tagen
-
Document architectural choicesEvtl. wieder frei @dicethedev hat das vor 115 Tagen übernommen, und es ist kein Pull Request offen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
lambdaclass/ethlambda#521 · 2 Kommentare ·
Maintainer antworten meist innerhalb von 6 Tagen
Alle Issues in lambdaclass/ethlambda
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 84/100
antithesishq/bombadil#473 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
bench/api.sh exec test fails with curl exit 52, and --ignore-failure still records the timingsOffenbug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
libracoder/kiri#669 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 88/100
Maintainer antworten meist innerhalb von 5 Tagen
-
autofixer: follow-up
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
tursodatabase/turso#12217 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Declare the CMS schema library in the optional recipients extraEvtl. vergeben Ein verknüpfter Pull Request ist offen oder bereits gemergt. Offenarea:python in-progress
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
yhay81/pyropdf#1005 · 2 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag