Phase0 epoch processing is quadratic: get_base_reward rescans the registry for every validator
Maintainers usually reply within 6 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 67/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust
- Domain
- backend, performance
Research direction
Start in crates/blockchain/state_transition/src/beacon/stf/epoch/rewards.rs, reading get_base_reward and the phase0 delta loops that call it. Compare how RewardContext in #632 passes precomputed balance for Altair and later; then run the phase0 fixtures and the era replay for mainnet era 290. Done means the epoch path avoids rescanning the registry per validator and those checks complete successfully.
Written by the indexing model from the issue text.
Description
Found by the era replay battery (#680): mainnet phase0 era 290 did not get through a single epoch boundary in 30 minutes, so phase0 eras are excluded from its matrix.
Cause (crates/blockchain/state_transition/src/beacon/stf/epoch/rewards.rs)
get_base_reward(line 71) callsget_total_active_balance(state)— a full registry scan — on every call.- It is called per validator from the phase0 delta loops (lines 118, 121, 125, 212, 246, and through
get_proposer_rewardat 82), so a phase0 epoch transition does O(validators) scans of O(validators) each: quadratic in the registry size. With the registry now a persistent tree (state.validator(i)is a descent), each scan is also more expensive than an array walk.
Fix
- Compute the total active balance (or the base reward per increment) once per epoch transition and pass it in, the way #632's
RewardContextalready does for altair and later, and #648 proposes for deneb/electra'sget_base_reward_per_increment. - The spec-literal
get_base_rewardcan stay as the reference the fixtures call, with the epoch path using the precomputed total.
Impact
- No live chain is in phase0, so this doesn't affect following mainnet today; it blocks replaying phase0 history in #680 and makes phase0 fixtures slower than they need to be.
- Once fixed, phase0 eras (e.g. mainnet 290) can be added back to the era replay matrix.
- Dominant language
- Rust
- Stars
- 86
- Forks
- 34
- Avg merge
- 9d 20h
- Merged PRs (30d)
- 77
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lambdaclass/ethlambda
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
lambdaclass/ethlambda#850 ·
Maintainers usually reply within 6 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
lambdaclass/ethlambda#777 · 1 reaction ·
Maintainers usually reply within 6 days
-
Run all gossip validation testsMay be free again @dicethedev claimed this 9 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
lambdaclass/ethlambda#725 · 2 comments ·
Maintainers usually reply within 6 days
-
Handle malformed DB dataMay be free again @dicethedev claimed this 115 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
lambdaclass/ethlambda#529 · 4 comments ·
Maintainers usually reply within 6 days
-
Document architectural choicesMay be free again @dicethedev claimed this 115 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
lambdaclass/ethlambda#521 · 2 comments ·
Maintainers usually reply within 6 days
All issues in lambdaclass/ethlambda
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
antithesishq/bombadil#473 ·
Maintainers usually reply within 2 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
libracoder/kiri#669 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 5 days
-
autofixer: follow-up
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
tursodatabase/turso#12217 ·
Maintainers usually reply within 1 day
-
Declare the CMS schema library in the optional recipients extraPossibly taken A pull request linked to this issue is open or already merged. Openarea:python in-progress
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
yhay81/pyropdf#1005 · 2 comments ·
Maintainers usually reply within 1 day