Phase0 epoch processing is quadratic: get_base_reward rescans the registry for every validator

Offen
#703 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 6 Tagen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
67/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
rust
Bereich
backend, performance

Rechercherichtung

Start in crates/blockchain/state_transition/src/beacon/stf/epoch/rewards.rs, reading get_base_reward and the phase0 delta loops that call it. Compare how RewardContext in #632 passes precomputed balance for Altair and later; then run the phase0 fixtures and the era replay for mainnet era 290. Done means the epoch path avoids rescanning the registry per validator and those checks complete successfully.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Found by the era replay battery (#680): mainnet phase0 era 290 did not get through a single epoch boundary in 30 minutes, so phase0 eras are excluded from its matrix.

Cause (crates/blockchain/state_transition/src/beacon/stf/epoch/rewards.rs)

  • get_base_reward (line 71) calls get_total_active_balance(state) — a full registry scan — on every call.
  • It is called per validator from the phase0 delta loops (lines 118, 121, 125, 212, 246, and through get_proposer_reward at 82), so a phase0 epoch transition does O(validators) scans of O(validators) each: quadratic in the registry size. With the registry now a persistent tree (state.validator(i) is a descent), each scan is also more expensive than an array walk.

Fix

  • Compute the total active balance (or the base reward per increment) once per epoch transition and pass it in, the way #632's RewardContext already does for altair and later, and #648 proposes for deneb/electra's get_base_reward_per_increment.
  • The spec-literal get_base_reward can stay as the reference the fixtures call, with the epoch path using the precomputed total.

Impact

  • No live chain is in phase0, so this doesn't affect following mainnet today; it blocks replaying phase0 history in #680 and makes phase0 fixtures slower than they need to be.
  • Once fixed, phase0 eras (e.g. mainnet 290) can be added back to the era replay matrix.
Vorherrschende Sprache
Rust
Sterne
86
Forks
34
Ø Merge
9 T. 20 Std.
Gemergte PRs (30 T.)
77

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus lambdaclass/ethlambda

Alle Issues in lambdaclass/ethlambda

Ähnliche Issues

Weitere Issues zu Rust

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.