Self-hosted platform: derive the R2 upload keys from the runtime API token
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 34/100
- issue の種類
- 機能追加
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- github, typescript
調査の方向性
Start with platform-lifecycle.ts, platform-management.ts, and platform-installer-secrets.ts; trace how runtime tokens and R2 credentials reach createPlatformInstallationSecrets and installPlatform. Check the token verification flow against platform/packages/api/src/email/cf-customer.ts and add coverage for both fallback directions, fresh installs, and token rotation. Done means derived credentials follow the specified precedence and recovery rules, with the docs updated and the Cloudflare token ID and presigned PUT behavior verified.
索引モデルが issue の本文から書いたものです。
説明
Problem
A self-hosted platform install asks for two extra pasted values on a separate
Cloudflare page: the R2 Access Key ID and Secret Access Key
(packages/void/src/cli/platform-lifecycle.ts, the R2 block after the GitHub
OAuth prompts; page platformSetupPages(plan).r2 in platform-setup.ts).
The keys are only used by the API Worker to presign direct-to-R2 asset PUTs
(platform/packages/api/src/routes/deploy.ts presignAssetPut,
platform/packages/api/src/r2-presign.ts). They are not checked at install time,
so a wrong pair only fails at the first void deploy --platform void that
uploads assets (packages/void/src/cli/direct-r2-upload.ts, raw
R2 PUT failed for <path> (<hash>): 403).
Cloudflare documents that an API token can act as an S3 key pair:
Access Key ID = the token ID, Secret Access Key = SHA-256 hex of the token value
(https://developers.cloudflare.com/r2/api/tokens/). The runtime token already
has Account → Workers R2 Storage → Edit, and the API Worker already holds it as
CF_API_TOKEN, so deriving the pair adds no new permission to any Worker.
Proposed design
fresh interactive or CI install
runtime token verified ──▶ GET /user/tokens/verify (fallback /accounts/:id/tokens/verify)
──▶ r2AccessKeyId = result.id
r2SecretAccessKey = sha256hex(runtime token)
explicit VOID_PLATFORM_R2_ACCESS_KEY_ID + _SECRET_ACCESS_KEY pair still wins
upgrade / repair with a new VOID_PLATFORM_RUNTIME_CLOUDFLARE_API_TOKEN
recovery r2SecretAccessKey == sha256hex(recovery cloudflareApiToken)? (or no recovery)
yes ──▶ derive again, update R2_* Worker secrets together with CF_API_TOKEN
no ──▶ keep the separately supplied pair
PlatformCloudflareClient.apiTokenId(accountId): token-verify lookup, returns a
non-empty id without whitespace, otherwise throws.platform-installer-secrets.ts:platformR2SecretFromToken,
platformR2KeysFollowRuntimeToken(recovery),platformR2CredentialsFromRuntimeToken.- Lifecycle: remove the R2 page and both prompts; derive after the runtime token
is verified. platform-management.ts: derive on runtime-token rotation when the saved
pair was derived from the previous token.- Docs: credentials.md (R2 section), ci.md (R2 rows optional), maintenance.md
(rotation replaces derived keys; recreating the API needs R2 values only for
a separate R2 token), development/runtime.md (drop R2 from needed inputs).
Problems to fix in this design before implementing
- Order in
platform-management.ts: the keys cannot be derived both before
createPlatformInstallationSecretsand after the runtime-token preflight, because
the preflight (resolvePlatformRuntimeTokenToPreflight(plan, secrets)) reads the
result ofcreatePlatformInstallationSecrets. Derive before
createPlatformInstallationSecretsand leave the preflight where it is; the
token-verify call already rejects an invalid token. - Token-ID lookup order: trying account verify first and falling back only on
401/403/404 is not enough. What/accounts/:id/tokens/verifyreturns for a user token is
unverified (it may be 400). Match
platform/packages/api/src/email/cf-customer.tsverifyToken(user verify
first, then account verify), or fall back on any 4xx except 429. Rethrow 5xx.
Test both fallback directions. - Precedence on a non-draft resume:
configured()in the lifecycle returns
values[key] || envwhencredentialSetupis false. Reading the env pair first
in every mode flips that; withexistingInstallationand no
updateExistingWorkers, the live API Worker keeps its old R2 secret while
recovery saves the env pair, and later hash matching compares the wrong value.
Apply the env pair only whencredentialSetupis true; otherwise keep the
checkpoint values. - "Set both or neither": a new error for a half-set env pair can break a resume
that works today (one variable set, the other from the checkpoint). Apply the
check only on a fresh install (credentialSetup).
Tests this design needs: derived values reach createPlatformInstallationSecrets
and installPlatform on a fresh interactive install (token id from a spied
apiTokenId, secret = sha256 of the runtime token); the half-set env pair
error; upgrade with a rotated runtime token updates R2_ACCESS_KEY_ID /
R2_SECRET_ACCESS_KEY only when the saved pair was derived.
Unverified before merge
/user/tokens/verifyor/accounts/:id/tokens/verifyreturnsidfor an
account-owned runtime token (cfat_…), and a presigned PUT signed with the
derived pair succeeds on the e2e account.- Without recovery data, a rotation would also rewrite a separately supplied
pair. It keeps working (the runtime token has R2 Edit), but it changes
"only supplied values replace live credentials"; docs must say so.
Related, separate
An install-time R2 key check would also catch a wrong pasted pair before the
first deploy (today it surfaces as a raw 403 from direct-r2-upload.ts).
🤖 Generated with Claude Code
- 主要言語
- TypeScript
- スター
- 402
- フォーク
- 32
- 平均マージ
- 12時間 1分
- マージ済み PR(30日)
- 80
環境構築
このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
voidzero-dev/void のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
voidzero-dev/void#484 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
voidzero-dev/void#463 ·
メンテナーはふだん 1 日以内に返信
-
Deploy after a secret change fails for Workers over ~750 KB: source read-back capped at 1 MiB対応中かも @Brooooooklyn が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
voidzero-dev/void#459 · 担当者 1 名 ·
メンテナーはふだん 1 日以内に返信
-
bug
難易度 1/5 1〜3時間 初心者へのやさしさ 78/100
voidzero-dev/void#428 ·
メンテナーはふだん 1 日以内に返信
-
Allow `npm create void` and `void init` to run without prompts対応中かも @ashunar0 が今日担当しました。 オープン
難易度 4/5 3〜5日 初心者へのやさしさ 57/100
voidzero-dev/void#491 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
voidzero-dev/void の issue をすべて見る
似ている issue
-
[测试] 等待仓库加载后再记录多仓库排序基线対応中かも @myot233 が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
メンテナーはふだん 1 日以内に返信
-
area:arcade p3-medium ready-for-agent testing type:docs
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
fderuiter/deruiter.dev#2369 ·
メンテナーはふだん 1 日以内に返信
-
area:devenv origin:agent type:bug
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
overengineeringstudio/effect-utils#1949 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
ccch1mneyyy/dsh-TUI#1631 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
MiniMax-AI/minimax-code#507 ·
メンテナーはふだん 1 日以内に返信