push reports a missing handle when TSCIRCUIT_TOKEN account lookup fails

オープン
#5,275 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@VB-Blue がすでに取り組んでいます。

2026年11月16日 から。

  • #5286 @danya0003 による — マージされずにクローズ
  • #5366 @prajwal-0706 による — マージされずにクローズ
  • #5441 @duongynhi000005-oss による — マージされずにクローズ
  • #5578 @1932819331hy-debug による — マージされずにクローズ
  • #5641 @tungnguyen84 による — マージされずにクローズ
  • #5659 @BrandoBlue による — マージされずにクローズ
  • #5733 @cocvn157 による — マージされずにクローズ
  • #5737 @jeffrey-graham による — マージされずにクローズ
  • #5826 @VB-Blue による — オープン

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
25/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
停滞
技術スタック
bun, typescript

調査の方向性

Start with lib/registry-api/fetch-account.ts and its callers in lib/shared/push-snippet.ts; inspect how lookup failures become null and how push, whoami, login, and initialization handle that result. Review the existing tests for environment-token publishing and expiry guidance, then add coverage for successful lookup, missing handles, HTTP errors, network errors, and malformed responses. Done means lookup failures preserve useful errors and exit nonzero, while a successfully retrieved account without a handle still gets the existing message.

索引モデルが issue の本文から書いたものです。

説明

Problem

tsci push reports that the user needs to set a tscircuit handle when an authenticated account lookup fails. It discards the underlying HTTP, network or response-parsing error, so a service failure or expired token is presented as missing account metadata.

We encountered this while making and publishing the USB-C rechargeable bicycle brake-light board entirely with tscircuit. The Devesh36 account already had a handle, and we were publishing from the cloud environment using TSCIRCUIT_TOKEN. The network/proxy returned HTTP 503 for the account lookup, but the CLI printed:

You need to set your tscircuit handle to publish packages

Publishing succeeded later when connectivity recovered, without setting a new handle.

Reproduction

The failure can be reproduced without a real token, registry outage or upload. From a CLI repository checkout with dependencies installed, run:

CLI_ENTRY="$PWD/cli/main.ts"
REPRO_DIR=$(mktemp -d)
cd "$REPRO_DIR"

cat > package.json <<'JSON'
{"name":"@tsci/test-user.handle-error-repro","version":"0.0.0"}
JSON

cat > index.circuit.tsx <<'TSX'
export default () => null
TSX

cat > mock-account-503.ts <<'TS'
globalThis.fetch = (async (input: Request | URL | string) => {
  const url = typeof input === "string" || input instanceof URL
    ? String(input) : input.url
  if (new URL(url).pathname === "/accounts/get") {
    return Response.json(
      { error: { error_code: "service_unavailable", message: "Simulated outage" } },
      { status: 503 },
    )
  }
  throw new Error("Unexpected request blocked by reproduction")
}) as typeof fetch
TS

TSCIRCUIT_TOKEN=placeholder-token \
TSCIRCUIT_CONFIG_DIR="$REPRO_DIR/.config" \
bun --preload ./mock-account-503.ts "$CLI_ENTRY" push index.circuit.tsx

Actual: missing-handle message, exit code 1. Only /accounts/get is attempted; no upload occurs.

Expected: an account-verification failure that preserves the service error, for example:

Could not verify your account for publishing: registry returned HTTP 503.
Retry when the registry is available.

The missing-handle message should apply only after successfully retrieving an account that actually lacks a handle.

Cause

When TSCIRCUIT_TOKEN is set, push-snippet.ts gets the publishing handle through fetchAccount().

fetch-account.ts catches every request/parsing exception and returns null. The caller then treats the absent handle as proof that the user must set one. This also swallows the HTTP client's existing expired-session guidance.

The environment-token publishing path was introduced in #5131. The saved-session path reads the cached handle directly and does not make this account lookup at that step.

Additional verification

We exercised 17 controlled CLI scenarios with placeholder tokens and intercepted requests. These all incorrectly produced the same missing-handle message:

  • HTTP 503, 401 with session_expired, 403 and 429;
  • connection failure and an injected timeout exception;
  • HTTP 200 with malformed JSON or a missing account object;
  • HTTP 503 even when a valid handle was already saved alongside the environment token.

A valid account with a handle passed account validation. A valid account without a handle correctly produced the existing message. No-token input correctly requested login. The success controls were stopped before any release lookup or publication, and all project manifests remained unchanged.

The shared helper also makes auth whoami print @(not set) and exit 0 after account lookup fails, and login can print Already logged in as @undefined! when no saved handle is available.

Suggested fix and regression coverage

Distinguish failed lookup from a successfully retrieved account with no handle, and report lookup failures with a nonzero exit code. Preserve useful authentication/status information. Do not fall back to a cached handle for an environment-token failure, since that token may identify another account.

Update affected callers of fetchAccount deliberately: push, whoami, login, and initialization's optional author lookup. Tests should cover a successful lookup, a genuinely missing handle, HTTP 503, expired token, network error and malformed response. Existing tests cover successful environment-token publishing and lower-level expiry messages but miss this swallowed-error path.

Environment

  • Observed and reproduced with [email protected], @tscircuit/[email protected], Bun 1.4.0.
  • The same implementation remains in reviewed upstream CLI 0.1.2294, commit 3945316bf27f9ff4ba2b16a1683b9c2810446f82.
主要言語
TypeScript
スター
19
フォーク
115
平均マージ
1時間 50分
マージ済み PR(30日)
260

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

tscircuit/cli のほかの issue

tscircuit/cli の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。