push reports a missing handle when TSCIRCUIT_TOKEN account lookup fails

Abierto
#5,275 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@VB-Blue ya está trabajando en esto.

Desde el 16/11/2026.

  • #5286 de @danya0003 — cerrado sin fusionar
  • #5366 de @prajwal-0706 — cerrado sin fusionar
  • #5441 de @duongynhi000005-oss — cerrado sin fusionar
  • #5578 de @1932819331hy-debug — cerrado sin fusionar
  • #5641 de @tungnguyen84 — cerrado sin fusionar
  • #5659 de @BrandoBlue — cerrado sin fusionar
  • #5733 de @cocvn157 — cerrado sin fusionar
  • #5737 de @jeffrey-graham — cerrado sin fusionar
  • #5826 de @VB-Blue — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
bun, typescript

Línea de trabajo

Start with lib/registry-api/fetch-account.ts and its callers in lib/shared/push-snippet.ts; inspect how lookup failures become null and how push, whoami, login, and initialization handle that result. Review the existing tests for environment-token publishing and expiry guidance, then add coverage for successful lookup, missing handles, HTTP errors, network errors, and malformed responses. Done means lookup failures preserve useful errors and exit nonzero, while a successfully retrieved account without a handle still gets the existing message.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem

tsci push reports that the user needs to set a tscircuit handle when an authenticated account lookup fails. It discards the underlying HTTP, network or response-parsing error, so a service failure or expired token is presented as missing account metadata.

We encountered this while making and publishing the USB-C rechargeable bicycle brake-light board entirely with tscircuit. The Devesh36 account already had a handle, and we were publishing from the cloud environment using TSCIRCUIT_TOKEN. The network/proxy returned HTTP 503 for the account lookup, but the CLI printed:

You need to set your tscircuit handle to publish packages

Publishing succeeded later when connectivity recovered, without setting a new handle.

Reproduction

The failure can be reproduced without a real token, registry outage or upload. From a CLI repository checkout with dependencies installed, run:

CLI_ENTRY="$PWD/cli/main.ts"
REPRO_DIR=$(mktemp -d)
cd "$REPRO_DIR"

cat > package.json <<'JSON'
{"name":"@tsci/test-user.handle-error-repro","version":"0.0.0"}
JSON

cat > index.circuit.tsx <<'TSX'
export default () => null
TSX

cat > mock-account-503.ts <<'TS'
globalThis.fetch = (async (input: Request | URL | string) => {
  const url = typeof input === "string" || input instanceof URL
    ? String(input) : input.url
  if (new URL(url).pathname === "/accounts/get") {
    return Response.json(
      { error: { error_code: "service_unavailable", message: "Simulated outage" } },
      { status: 503 },
    )
  }
  throw new Error("Unexpected request blocked by reproduction")
}) as typeof fetch
TS

TSCIRCUIT_TOKEN=placeholder-token \
TSCIRCUIT_CONFIG_DIR="$REPRO_DIR/.config" \
bun --preload ./mock-account-503.ts "$CLI_ENTRY" push index.circuit.tsx

Actual: missing-handle message, exit code 1. Only /accounts/get is attempted; no upload occurs.

Expected: an account-verification failure that preserves the service error, for example:

Could not verify your account for publishing: registry returned HTTP 503.
Retry when the registry is available.

The missing-handle message should apply only after successfully retrieving an account that actually lacks a handle.

Cause

When TSCIRCUIT_TOKEN is set, push-snippet.ts gets the publishing handle through fetchAccount().

fetch-account.ts catches every request/parsing exception and returns null. The caller then treats the absent handle as proof that the user must set one. This also swallows the HTTP client's existing expired-session guidance.

The environment-token publishing path was introduced in #5131. The saved-session path reads the cached handle directly and does not make this account lookup at that step.

Additional verification

We exercised 17 controlled CLI scenarios with placeholder tokens and intercepted requests. These all incorrectly produced the same missing-handle message:

  • HTTP 503, 401 with session_expired, 403 and 429;
  • connection failure and an injected timeout exception;
  • HTTP 200 with malformed JSON or a missing account object;
  • HTTP 503 even when a valid handle was already saved alongside the environment token.

A valid account with a handle passed account validation. A valid account without a handle correctly produced the existing message. No-token input correctly requested login. The success controls were stopped before any release lookup or publication, and all project manifests remained unchanged.

The shared helper also makes auth whoami print @(not set) and exit 0 after account lookup fails, and login can print Already logged in as @undefined! when no saved handle is available.

Suggested fix and regression coverage

Distinguish failed lookup from a successfully retrieved account with no handle, and report lookup failures with a nonzero exit code. Preserve useful authentication/status information. Do not fall back to a cached handle for an environment-token failure, since that token may identify another account.

Update affected callers of fetchAccount deliberately: push, whoami, login, and initialization's optional author lookup. Tests should cover a successful lookup, a genuinely missing handle, HTTP 503, expired token, network error and malformed response. Existing tests cover successful environment-token publishing and lower-level expiry messages but miss this swallowed-error path.

Environment

  • Observed and reproduced with [email protected], @tscircuit/[email protected], Bun 1.4.0.
  • The same implementation remains in reviewed upstream CLI 0.1.2294, commit 3945316bf27f9ff4ba2b16a1683b9c2810446f82.
Lenguaje dominante
TypeScript
Estrellas
19
Forks
115
Merge medio
1 h 50 min
PR fusionados (30 d)
260

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de tscircuit/cli

Todos los issues de tscircuit/cli

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.