Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Test coverage gap: run_command logic in the recent parity sweep is untested

オープン
  • 何か問題がありますか？
#457 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 11 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
58/100
issue の種類
リファクタリング
明瞭さ
明確に書かれている
活発さ
静か
技術スタック
python
領域
cli, testing

調査の方向性

Start with the run_command paths described for #451, #452, #447, #448, and #444, using tests/commands/test_create_site_users.py as the testing pattern. Mock the relevant server endpoint methods, invoke Command.run_command(args), and assert that the items passed to them contain the expected normalized or assigned attributes across the covered happy paths.

索引モデルが issue の本文から書いたものです。

説明

Several PRs in the current Classic-parity sweep add argparse-layer tests
but no coverage of the load-bearing logic in run_command where the
parsed args actually get applied to TSC items or normalized. This is a
common pattern across the sweep, not a single-PR issue, so recording
here as a follow-up rather than blocking those PRs.

Concrete gaps

#451 delete syntax normalization. run_command transforms
isinstance(args.workbook, str) -> args.name = args.workbook; args.workbook = True (and same for datasource). This is what makes both
delete Name --workbook and Classic delete --workbook Name produce
equivalent behavior. No test covers the transform; both syntaxes are
verified at the parser layer only. If someone refactors run_command
and drops the normalization, every parser test still passes but Classic
scripts break silently.

#452 editsite attribute application. run_command reads ten new
argparse fields onto SiteItem attributes with three separate patterns:
_str_to_bool coercion for the string-value flags, direct assignment
for the paired boolean flags, and inversion for disable_subscriptions
(from allow_subscriptions). The paired custom_subscription_email +
custom_subscription_email_enabled writes on --subscription-email
(where empty string flips _enabled off) also live in run_command.
None of this is exercised by a mocked server.sites.update call. A
future refactor could drop any of these assignments and no test would
catch it.

#447 creategroup --role. run_command sets
GroupItem.minimum_site_role = args.role before
server.groups.create. Not tested; someone could delete the assignment
and every parser test still passes.

#448 publish --description. run_command sets
new_item.description = args.description on the WorkbookItem or
DatasourceItem before publish. Not tested; same failure mode.

#444 --idp-configuration-id. run_command sets
user_obj.idp_configuration_id = args.idp_configuration_id on every
UserItem in the batch, and apply_cli_overrides clears any pre-existing
auth_setting when the IDP flag is passed. Only the
apply_cli_overrides helper is tested; nothing verifies the attribute
actually reaches the wire.

Suggested shape

Adopt a pattern like tests/commands/test_create_site_users.py uses:
mock the Session/server, mock server.<endpoint>.<method>, invoke
Command.run_command(args), assert the item passed to
server.<endpoint>.<method> has the expected attributes set. Not
required per-flag -- one test per PR covering the main happy path is
enough to lock in the wire-level behavior.

Not tracking here

  • #451 bare --workbook with no value: parser accepts, run_command
    errors out. Already covered at the parser layer; run_command's error
    message is standard.
  • Command-level auth and session setup: shared across all commands and
    tested elsewhere.
  • #455 createsiteusers: already has run_command coverage
    (test_create_site_users.py); the gap is elsewhere.
主要言語
Python
スター
52
フォーク
17
平均マージ
11日 11時間
マージ済み PR（30日）
4

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

tableau/tabcmd のほかの issue

tableau/tabcmd の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。