The sign-up dialog decides "See alternatives" with its own copy of the rule behind "Pick another slot."

オープン
  • 何か問題がありますか？
#803 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@dafeiyupola がすでに取り組んでいます。

2026年11月6日 から。

  • #806 @dafeiyupola による — オープン

評価

難易度
2/5
見積もり時間
1〜3時間
初心者へのやさしさ
25/100
issue の種類
リファクタリング
明瞭さ
明確に書かれている
活発さ
停滞
技術スタック
next.js, react, typescript
領域
frontend, testing

調査の方向性

Read src/app/s/[slug]/capacity-message.ts and src/app/s/[slug]/commit-dialog.tsx, then inspect src/app/s/[slug]/capacity-message.test.ts and the server's SlotAlternative type in src/services/commitments.ts. Add a unit test for empty and missing alternatives, and confirm the shared rule drives both the suggestion and link; the issue also requires the listed lint, format, typecheck, knip, and test commands to pass. Pull request #806 is already open.

索引モデルが issue の本文から書いたものです。

説明

enhancement good first issue pipeline:ready

What happens

When a slot fills while someone is signing up, the dialog decides twice whether to point them at other slots:

  • The words. capacityMessage in src/app/s/[slug]/capacity-message.ts adds "Pick another slot." only when the error is capacity_full, remaining and requested are numbers, remaining <= 0, and details.alternatives is a non-empty array.
  • The link. CommitDialog in src/app/s/[slug]/commit-dialog.tsx shows its "See alternatives" link with its own inline check: error.details?.alternatives?.length && error.details.remaining === 0. That check doesn't look at the error code or requested, and uses === 0 where the other uses <= 0.

The dialog's local ApiError type also describes the alternatives wrongly, as { id: string; title: string }[]. The server sends SlotAlternative, which is { id, ref, slotAt } (src/services/commitments.ts). Nothing reads title, so nothing renders wrong, but the type misleads the next person who does.

Today the two checks agree on every payload the server can send, because capacityFull always sends remaining and requested as numbers and clamps remaining at 0. They only disagree on payloads the server never sends. So this is drift waiting to happen, and nobody sees a difference now.

Fix, in outline

  • In capacity-message.ts, export one small function (for example offersAlternatives(error)) that holds the rule: capacity_full, a finite remaining <= 0, and a non-empty alternatives array. Use it in capacityMessage's join branch.
  • In commit-dialog.tsx, show "See alternatives" from that same function instead of the inline condition.
  • Fix the alternatives type in the dialog's ApiError to match SlotAlternative (or unknown[], since only its length is used).
  • Add a unit test in capacity-message.test.ts for the new function, including an empty alternatives array and a payload with no alternatives key (the change-quantity path sends none).

Watch for

  • No visible change. The hint and the link must still appear together, only when the slot is full and the server found at least one open slot. The wording and the link target (/s/<slug>) stay as they are.
  • Server side is done. #782 / #787 fixed which slots the server offers. Leave src/services/commitments.ts alone.
  • participantErrorCopy in participant-error.ts calls capacityMessage; it shouldn't need to change.

Done when

  • The "See alternatives" link and the "Pick another slot." suggestion are decided by one function.
  • The dialog's alternatives type matches what the server sends.
  • A unit test pins the function.
  • pnpm lint && pnpm format:check && pnpm typecheck && pnpm knip && pnpm test pass.

Found by the pipeline's refactor scout in the participant pages (src/app/s/[slug]), at d1e9e14. Checked by an independent verify agent, which ran a scratch vitest of both conditions over every payload shape the server sends (19 of 19 agree) and over synthetic ones where they differ, and grepped every use of alternatives. https://claude.ai/code/session_016YZ9SSPmh7nC1k9RsPc5NE

主要言語
TypeScript
スター
19
フォーク
4
平均マージ
19時間 27分
マージ済み PR（30日）
199

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

richshaw/OpenSignup のほかの issue

richshaw/OpenSignup の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。