The sign-up dialog decides "See alternatives" with its own copy of the rule behind "Pick another slot."

Abierto
  • ¿Algo no está bien?
#803 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@dafeiyupola ya está trabajando en esto.

Desde el 6/11/2026.

  • #806 de @dafeiyupola — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
25/100
Tipo de issue
Refactorización
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
next.js, react, typescript
Área
frontend, testing

Línea de trabajo

Read src/app/s/[slug]/capacity-message.ts and src/app/s/[slug]/commit-dialog.tsx, then inspect src/app/s/[slug]/capacity-message.test.ts and the server's SlotAlternative type in src/services/commitments.ts. Add a unit test for empty and missing alternatives, and confirm the shared rule drives both the suggestion and link; the issue also requires the listed lint, format, typecheck, knip, and test commands to pass. Pull request #806 is already open.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement good first issue pipeline:ready

What happens

When a slot fills while someone is signing up, the dialog decides twice whether to point them at other slots:

  • The words. capacityMessage in src/app/s/[slug]/capacity-message.ts adds "Pick another slot." only when the error is capacity_full, remaining and requested are numbers, remaining <= 0, and details.alternatives is a non-empty array.
  • The link. CommitDialog in src/app/s/[slug]/commit-dialog.tsx shows its "See alternatives" link with its own inline check: error.details?.alternatives?.length && error.details.remaining === 0. That check doesn't look at the error code or requested, and uses === 0 where the other uses <= 0.

The dialog's local ApiError type also describes the alternatives wrongly, as { id: string; title: string }[]. The server sends SlotAlternative, which is { id, ref, slotAt } (src/services/commitments.ts). Nothing reads title, so nothing renders wrong, but the type misleads the next person who does.

Today the two checks agree on every payload the server can send, because capacityFull always sends remaining and requested as numbers and clamps remaining at 0. They only disagree on payloads the server never sends. So this is drift waiting to happen, and nobody sees a difference now.

Fix, in outline

  • In capacity-message.ts, export one small function (for example offersAlternatives(error)) that holds the rule: capacity_full, a finite remaining <= 0, and a non-empty alternatives array. Use it in capacityMessage's join branch.
  • In commit-dialog.tsx, show "See alternatives" from that same function instead of the inline condition.
  • Fix the alternatives type in the dialog's ApiError to match SlotAlternative (or unknown[], since only its length is used).
  • Add a unit test in capacity-message.test.ts for the new function, including an empty alternatives array and a payload with no alternatives key (the change-quantity path sends none).

Watch for

  • No visible change. The hint and the link must still appear together, only when the slot is full and the server found at least one open slot. The wording and the link target (/s/<slug>) stay as they are.
  • Server side is done. #782 / #787 fixed which slots the server offers. Leave src/services/commitments.ts alone.
  • participantErrorCopy in participant-error.ts calls capacityMessage; it shouldn't need to change.

Done when

  • The "See alternatives" link and the "Pick another slot." suggestion are decided by one function.
  • The dialog's alternatives type matches what the server sends.
  • A unit test pins the function.
  • pnpm lint && pnpm format:check && pnpm typecheck && pnpm knip && pnpm test pass.

Found by the pipeline's refactor scout in the participant pages (src/app/s/[slug]), at d1e9e14. Checked by an independent verify agent, which ran a scratch vitest of both conditions over every payload shape the server sends (19 of 19 agree) and over synthetic ones where they differ, and grepped every use of alternatives. https://claude.ai/code/session_016YZ9SSPmh7nC1k9RsPc5NE

Lenguaje dominante
TypeScript
Estrellas
19
Forks
4
Merge medio
19 h 27 min
PR fusionados (30 d)
199

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de richshaw/OpenSignup

Todos los issues de richshaw/OpenSignup

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.