Two breadcrumb pages belong to URLs that always redirect, so they never show

オープン
  • 何か問題がありますか？
#793 コメント 1 件 リアクション 0 件 担当者 1 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@richshaw がすでに取り組んでいます。

2026年11月4日 から。

評価

この issue はまだ評価されていません。

説明

enhancement good first issue pipeline:stuck

What happens

The organizer breadcrumb is a parallel route, src/app/app/(chrome)/@crumbs. Two of its pages pair with organizer pages that do nothing but redirect, so neither crumb is ever seen.

  • @crumbs/signups/[id]/edit/page.tsx (22 lines). It loads the signup with loadSignupForOrganizer and renders "‹title› › Edit": a hand copy of what SignupTitleCrumb (src/components/chrome/SignupTitleCrumb.tsx) does, plus an "Edit" crumb. Its page, signups/[id]/edit/page.tsx, only redirects to /settings. It stays for old links; src/mcp/links.ts says as much.
  • @crumbs/signups/[id]/page.tsx (1 line, re-exports SignupTitleCrumb). Its page, signups/[id]/page.tsx, only redirects to /build.

The slot does render on the redirected request, but only into the 307 response body, which the browser throws away. The final page shows its own crumb. "Edit" never appears anywhere.

Fix, in outline

  • Delete src/app/app/(chrome)/@crumbs/signups/[id]/edit/page.tsx and its now-empty edit/ folder.
  • Delete src/app/app/(chrome)/@crumbs/signups/[id]/page.tsx.
  • Keep both redirect pages. /app/signups/<id> is linked from the dashboard and from the New signup action, and /edit serves old links. @crumbs/default.tsx (returns null) covers both URLs once the slot pages are gone.

Watch for

  • Restart a running dev server after deleting them. pnpm dev keeps a stale reference and returns 500 ("Can't resolve …@crumbs/signups/[id]/edit/page") until restarted. That's the dev build, not a real problem.
  • Don't expect a query saving. Statement counts on both redirected URLs were the same with and without the crumb files: the crumb's reads are deduped by React cache() against signups/[id]/layout.tsx. This is about dead code and a stray copy of SignupTitleCrumb, not speed.
  • No visible change. Every organizer page's breadcrumb should read the same before and after.

Done when

  • Both files are gone, and nothing else under @crumbs changed.
  • Opening /app/signups/<id> and /app/signups/<id>/edit still lands on /build and /settings with "OpenSignup › ‹title›", by hard and by soft navigation. The existing e2e specs that open /app/signups/<id> still pass.
  • pnpm lint && pnpm format:check && pnpm typecheck && pnpm knip && pnpm test pass.

Found by the pipeline's refactor scout in the organizer chrome (src/app/app/(chrome)), at be0c273. Checked by an independent verify agent that ran the app with the two files and without them. It compared the redirects (307 to /settings and /build), the breadcrumb after hard and soft navigation, and the Postgres statement counts: all identical. https://claude.ai/code/session_016YZ9SS4Qrr2sRQj4bhaMwW

主要言語
TypeScript
スター
19
フォーク
4
平均マージ
19時間 27分
マージ済み PR（30日）
199

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

richshaw/OpenSignup のほかの issue

richshaw/OpenSignup の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。