Two breadcrumb pages belong to URLs that always redirect, so they never show

未关闭
  • 哪里不对？
#793 1 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 1 天内回复

@richshaw 已经在做这个了。

开始于 2026年11月4日。

  • #812 来自 @dafeiyupola —— 未关闭

评估

这个 Issue 还没有评估数据。

描述

enhancement good first issue pipeline:stuck

What happens

The organizer breadcrumb is a parallel route, src/app/app/(chrome)/@crumbs. Two of its pages pair with organizer pages that do nothing but redirect, so neither crumb is ever seen.

  • @crumbs/signups/[id]/edit/page.tsx (22 lines). It loads the signup with loadSignupForOrganizer and renders "‹title› › Edit": a hand copy of what SignupTitleCrumb (src/components/chrome/SignupTitleCrumb.tsx) does, plus an "Edit" crumb. Its page, signups/[id]/edit/page.tsx, only redirects to /settings. It stays for old links; src/mcp/links.ts says as much.
  • @crumbs/signups/[id]/page.tsx (1 line, re-exports SignupTitleCrumb). Its page, signups/[id]/page.tsx, only redirects to /build.

The slot does render on the redirected request, but only into the 307 response body, which the browser throws away. The final page shows its own crumb. "Edit" never appears anywhere.

Fix, in outline

  • Delete src/app/app/(chrome)/@crumbs/signups/[id]/edit/page.tsx and its now-empty edit/ folder.
  • Delete src/app/app/(chrome)/@crumbs/signups/[id]/page.tsx.
  • Keep both redirect pages. /app/signups/<id> is linked from the dashboard and from the New signup action, and /edit serves old links. @crumbs/default.tsx (returns null) covers both URLs once the slot pages are gone.

Watch for

  • Restart a running dev server after deleting them. pnpm dev keeps a stale reference and returns 500 ("Can't resolve …@crumbs/signups/[id]/edit/page") until restarted. That's the dev build, not a real problem.
  • Don't expect a query saving. Statement counts on both redirected URLs were the same with and without the crumb files: the crumb's reads are deduped by React cache() against signups/[id]/layout.tsx. This is about dead code and a stray copy of SignupTitleCrumb, not speed.
  • No visible change. Every organizer page's breadcrumb should read the same before and after.

Done when

  • Both files are gone, and nothing else under @crumbs changed.
  • Opening /app/signups/<id> and /app/signups/<id>/edit still lands on /build and /settings with "OpenSignup › ‹title›", by hard and by soft navigation. The existing e2e specs that open /app/signups/<id> still pass.
  • pnpm lint && pnpm format:check && pnpm typecheck && pnpm knip && pnpm test pass.

Found by the pipeline's refactor scout in the organizer chrome (src/app/app/(chrome)), at be0c273. Checked by an independent verify agent that ran the app with the two files and without them. It compared the redirects (307 to /settings and /build), the breadcrumb after hard and soft navigation, and the Postgres statement counts: all identical. https://claude.ai/code/session_016YZ9SS4Qrr2sRQj4bhaMwW

主要语言
TypeScript
星标
19
派生
4
平均合并
18 小时 44 分钟
30 天内合并 PR
211

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

richshaw/OpenSignup 的其他 Issue

查看 richshaw/OpenSignup 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。