additional variables for hooks, especially the path of the mounted partition

オープン
#582 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
領域
backend

調査の方向性

Start by tracing how Timeshift invokes hook scripts and sets the existing TS_SNAPSHOT_PATH variable, then check how the mounted root path, snapshot mode, and live system state are detected. The issue does not name source files or tests, so locate those entry points in the repository first. Done means hook scripts can read variables for the mounted partition path, BTRFS or rsync mode, and live system status.

索引モデルが issue の本文から書いたものです。

説明

Is your feature request related to a problem? Please describe.
thanks to #381 i'm working on scripts to also include resp. restore separate boot and efi partitions. it works quite well for now, but i want to extend them to also work on live systems and also cover the rsync mode and not just BTRFS. - basically that i don't have to think about the particular setup every time; just place the scripts in the hook folders and run Timeshift unless it is really an out of the box setup.
to make that work correctly, i need the path to the by Timeshift mounted root partition... in the BTRFS mode i can use the variable ${TS_SNAPSHOT_PATH} and go 3 levels up, but in the rsync mode this doesn't work because the snapshots are stored somewhere else entirely. 😒

Describe the solution you'd like
a solution to make it work easily would be an additional variable "TS_PARTITION_PATH" or the like with the path of the by Timeshift mounted partition.
...and while we are at it, it would also be quite convenient to have a variable indicating if Timeshift is working in BTRFS or rsync mode (e.g. "TS_MODE") and if it is running on a live system (e.g. "TS_LIVE_SYSTEM").

Describe alternatives you've considered

  • i'm not sure what would be the best method of getting the correct(!) PID to guess the right path; because https://github.com/teejee2008/timeshift/issues/922#issuecomment-1220780174 confirms, that just searching for a timshift process wouldn't work reliable... but no matter how, it seems somewhat rickety to me.
  • for the Timeshift mode i parse '/etc/timeshift/timeshift.json' for now but a variable would avoid the dependence on jq and make things easier.
  • for now i'm thinking about some checks if Timeshift is working on a live system, but if Timeshift itself is aware of that (is it? 🤔), it would be the best to get the information directly from Timeshift without fiddling around separately.
主要言語
Vala
スター
4.3k
フォーク
162
PR マージ指標
30日以内にマージされた PR はありません

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

linuxmint/timeshift のほかの issue

linuxmint/timeshift の issue をすべて見る

似ている issue

Backend & API Design の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。