additional variables for hooks, especially the path of the mounted partition
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 48/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Área
- backend
Línea de trabajo
Start by tracing how Timeshift invokes hook scripts and sets the existing TS_SNAPSHOT_PATH variable, then check how the mounted root path, snapshot mode, and live system state are detected. The issue does not name source files or tests, so locate those entry points in the repository first. Done means hook scripts can read variables for the mounted partition path, BTRFS or rsync mode, and live system status.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Is your feature request related to a problem? Please describe.
thanks to #381 i'm working on scripts to also include resp. restore separate boot and efi partitions. it works quite well for now, but i want to extend them to also work on live systems and also cover the rsync mode and not just BTRFS. - basically that i don't have to think about the particular setup every time; just place the scripts in the hook folders and run Timeshift unless it is really an out of the box setup.
to make that work correctly, i need the path to the by Timeshift mounted root partition... in the BTRFS mode i can use the variable ${TS_SNAPSHOT_PATH} and go 3 levels up, but in the rsync mode this doesn't work because the snapshots are stored somewhere else entirely. 😒
Describe the solution you'd like
a solution to make it work easily would be an additional variable "TS_PARTITION_PATH" or the like with the path of the by Timeshift mounted partition.
...and while we are at it, it would also be quite convenient to have a variable indicating if Timeshift is working in BTRFS or rsync mode (e.g. "TS_MODE") and if it is running on a live system (e.g. "TS_LIVE_SYSTEM").
Describe alternatives you've considered
- i'm not sure what would be the best method of getting the correct(!) PID to guess the right path; because https://github.com/teejee2008/timeshift/issues/922#issuecomment-1220780174 confirms, that just searching for a
timshiftprocess wouldn't work reliable... but no matter how, it seems somewhat rickety to me. - for the Timeshift mode i parse '/etc/timeshift/timeshift.json' for now but a variable would avoid the dependence on
jqand make things easier. - for now i'm thinking about some checks if Timeshift is working on a live system, but if Timeshift itself is aware of that (is it? 🤔), it would be the best to get the information directly from Timeshift without fiddling around separately.
- Lenguaje dominante
- Vala
- Estrellas
- 4.3k
- Forks
- 162
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Preparar el entorno
Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de linuxmint/timeshift
-
Delete snapshots: number mismatchPosiblemente ocupada @EthanNoble la tomó hace 6 días. Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 72/100
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 78/100
-
License parsing with GitHubAbierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 68/100
-
Dificultad 3/5 1-2 días Aptitud para principiantes 45/100
-
Dificultad 3/5 Medio día Aptitud para principiantes 55/100
Todos los issues de linuxmint/timeshift
Issues similares
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
PixelPlayerHQ/PixelPlayerOSS#254 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
389ds/389-ds-base#8152 ·
Los mantenedores suelen responder en 2 días
-
Bug feat:Syntax
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
ignatov/intellij-erlang#1342 ·
Los mantenedores suelen responder en 1 día
-
intcomma returns exponential notation for large floatsPosiblemente ocupada @Omarinho12345 la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
python-humanize/humanize#521 ·
Los mantenedores suelen responder en 1 día
-
🧑💻 tech-debt
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
guibranco/gstraccini-bot-service#1206 ·
Los mantenedores suelen responder en 1 día