additional variables for hooks, especially the path of the mounted partition

Aperta
#582 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Ambito
backend

Direzione di ricerca

Start by tracing how Timeshift invokes hook scripts and sets the existing TS_SNAPSHOT_PATH variable, then check how the mounted root path, snapshot mode, and live system state are detected. The issue does not name source files or tests, so locate those entry points in the repository first. Done means hook scripts can read variables for the mounted partition path, BTRFS or rsync mode, and live system status.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Is your feature request related to a problem? Please describe.
thanks to #381 i'm working on scripts to also include resp. restore separate boot and efi partitions. it works quite well for now, but i want to extend them to also work on live systems and also cover the rsync mode and not just BTRFS. - basically that i don't have to think about the particular setup every time; just place the scripts in the hook folders and run Timeshift unless it is really an out of the box setup.
to make that work correctly, i need the path to the by Timeshift mounted root partition... in the BTRFS mode i can use the variable ${TS_SNAPSHOT_PATH} and go 3 levels up, but in the rsync mode this doesn't work because the snapshots are stored somewhere else entirely. 😒

Describe the solution you'd like
a solution to make it work easily would be an additional variable "TS_PARTITION_PATH" or the like with the path of the by Timeshift mounted partition.
...and while we are at it, it would also be quite convenient to have a variable indicating if Timeshift is working in BTRFS or rsync mode (e.g. "TS_MODE") and if it is running on a live system (e.g. "TS_LIVE_SYSTEM").

Describe alternatives you've considered

  • i'm not sure what would be the best method of getting the correct(!) PID to guess the right path; because https://github.com/teejee2008/timeshift/issues/922#issuecomment-1220780174 confirms, that just searching for a timshift process wouldn't work reliable... but no matter how, it seems somewhat rickety to me.
  • for the Timeshift mode i parse '/etc/timeshift/timeshift.json' for now but a variable would avoid the dependence on jq and make things easier.
  • for now i'm thinking about some checks if Timeshift is working on a live system, but if Timeshift itself is aware of that (is it? 🤔), it would be the best to get the information directly from Timeshift without fiddling around separately.
Lingua principale
Vala
Stelle
4.3k
Fork
162
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di linuxmint/timeshift

Tutte le issue di linuxmint/timeshift

Issue simili

Altre issue su Backend & API Design

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.